Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for #66421 #73052

Merged
merged 1 commit into from
Jul 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ public async Task IgnoreCycles_OnDictionary(Type typeToSerialize)
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task IgnoreCycles_OnRecursiveDictionary()
{
var root = new RecursiveDictionary();
Expand Down Expand Up @@ -183,9 +180,6 @@ public async Task IgnoreCycles_OnList(Type typeToSerialize)
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task IgnoreCycles_OnRecursiveList()
{
var root = new RecursiveList();
Expand Down Expand Up @@ -240,9 +234,6 @@ public async Task IgnoreCycles_OnExtensionData()
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
{
// Object
Expand Down Expand Up @@ -279,9 +270,6 @@ public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task IgnoreCycles_DoesNotSupportPreserveSemantics_Polymorphic()
{
// Object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@ public async Task UnicodePropertyNames()
public class DictionaryWithGenericCycle : Dictionary<string, DictionaryWithGenericCycle> { }

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task DictionaryLoop()
{
DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
Expand All @@ -261,9 +258,6 @@ public async Task DictionaryLoop()
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task DictionaryPreserveDuplicateDictionaries()
{
DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
Expand Down Expand Up @@ -298,9 +292,6 @@ public async Task DictionaryObjectLoop()
public class DictionaryWithGenericCycleWithinList : Dictionary<string, List<DictionaryWithGenericCycleWithinList>> { }

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task DictionaryArrayLoop()
{
DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
Expand All @@ -316,9 +307,6 @@ public async Task DictionaryArrayLoop()
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task DictionaryPreserveDuplicateArrays()
{
DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
Expand Down Expand Up @@ -449,9 +437,6 @@ public async Task UnicodeDictionaryKeys()
public class ListWithGenericCycle : List<ListWithGenericCycle> { }

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task ArrayLoop()
{
ListWithGenericCycle root = new ListWithGenericCycle();
Expand Down Expand Up @@ -518,9 +503,6 @@ public async Task ArrayPreserveDuplicateObjects()
public class ListWithGenericCycleWithinDictionary : List<Dictionary<string, ListWithGenericCycleWithinDictionary>> { }

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task ArrayDictionaryLoop()
{
ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary();
Expand All @@ -536,9 +518,6 @@ public async Task ArrayDictionaryLoop()
}

[Fact]
#if BUILDING_SOURCE_GENERATOR_TESTS
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
#endif
public async Task ArrayPreserveDuplicateDictionaries()
{
ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary
Expand Down