Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Reenable disabled tests as mono now respects non-public custom attributes in dynamic assemblies #88322

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Jul 3, 2023

This PR reenables tests that were previously disabled because of: #60650 which was recently fixed via: #87406

@ghost
Copy link

ghost commented Jul 3, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR reenables tests that previously disabled because of: #60650 which was recently fixed via: #87406

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

area-System.Runtime.InteropServices

Milestone: -

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member

ios-like platform failures due to #88186

…r.Pulse are not supported on single-threaded WASM
@lambdageek
Copy link
Member

@ivanpovazan I think probably all the analyzer and source generator unit tests will need to be skipped on the (single-threaded) browser platform. probably a lot of the underlying infrastructure depends on concurrency

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

Failures are unrelated

@ivanpovazan ivanpovazan merged commit 01c9a84 into dotnet:main Jul 4, 2023
209 of 240 checks passed
@ivanpovazan ivanpovazan deleted the enable-cattr-tests branch July 4, 2023 13:03
@ghost ghost locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants