Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Reenable disabled tests as mono now respects non-public custom attributes in dynamic assemblies #88322

Merged
merged 2 commits into from
Jul 4, 2023
Merged

[mono] Reenable disabled tests as mono now respects non-public custom attributes in dynamic assemblies #88322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e939e39
Reenable disabled tests
ivanpovazan Jul 3, 2023
fffa362
Disable Roslyn analyzer tests in the browser as Monitor.Wait / Monito…
ivanpovazan Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...trinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLibUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace IntrinsicsInSystemPrivateCoreLib.Test
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class IntrinsicsInSystemPrivateCoreLibUnitTest
{
string BoilerPlate = @"
Expand Down
1 change: 0 additions & 1 deletion ...ntime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace ComInterfaceGenerator.Unit.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class AddGeneratedComClassTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...ts/ComInterfaceGenerator.Unit.Tests/ComHostingDoesNotSupportGeneratedComInterfaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace ComInterfaceGenerator.Unit.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class ComHostingDoesNotSupportGeneratedComInterfaceTests
{
[InlineData(true)]
Expand Down
1 change: 0 additions & 1 deletion ...ropServices/tests/ComInterfaceGenerator.Unit.Tests/ConvertToGeneratedComInterfaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace ComInterfaceGenerator.Unit.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class ConvertToGeneratedComInterfaceTests
{
[Fact]
Expand Down
5 changes: 0 additions & 5 deletions ...eropServices/tests/ComInterfaceGenerator.Unit.Tests/GeneratedComInterfaceAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace ComInterfaceGenerator.Unit.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class GeneratedComInterfaceAnalyzerTests
{
static string _usings = $$"""
Expand All @@ -21,7 +20,6 @@ public class GeneratedComInterfaceAnalyzerTests
#pragma warning restore CS8019
""";

[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class InterfaceHasInterfaceTypeAttributeOnly
{
[Fact]
Expand Down Expand Up @@ -143,7 +141,6 @@ void Bar() {}
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class InterfaceHasGeneratedComInterfaceAttributeOnly
{
[Fact]
Expand All @@ -162,7 +159,6 @@ void Bar() {}
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class InterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
{
[Fact]
Expand Down Expand Up @@ -318,7 +314,6 @@ await VerifyCS.VerifyAnalyzerAsync(
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class PartialInterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...s/tests/ComInterfaceGenerator.Unit.Tests/RuntimeComApiUsageWithSourceGeneratedComTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

namespace ComInterfaceGenerator.Unit.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class RuntimeComApiUsageWithSourceGeneratedComTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class AddDisableRuntimeMarshallingAttributeFixerTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...ropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class ConvertToLibraryImportAnalyzerTests
{
public static IEnumerable<object[]> MarshallingRequiredTypes() => new[]
Expand Down
1 change: 0 additions & 1 deletion ...nteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportFixerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class ConvertToLibraryImportFixerTests
{
private const string ConvertToLibraryImportKey = "ConvertToLibraryImport";
Expand Down
1 change: 0 additions & 1 deletion ...ts/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_AttributeUsage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class CustomMarshallerAttributeAnalyzerTests_AttributeUsage
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ....UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class CustomMarshallerAttributeAnalyzerTests_StatefulLinearCollectionShapeValidation
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...rtGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class CustomMarshallerAttributeAnalyzerTests_StatefulValueShapeValidation
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class CustomMarshallerAttributeAnalyzerTests_StatelessLinearCollectionShapeValidation
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...tGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class CustomMarshallerAttributeAnalyzerTests_StatelessValueShapeValidation
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...ervices/tests/LibraryImportGenerator.UnitTests/NativeMarshallingAttributeAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class NativeMarshallingAttributeAnalyzerTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion ...Services/tests/LibraryImportGenerator.UnitTests/ShapeBreakingDiagnosticSuppressorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

namespace LibraryImportGenerator.UnitTests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
public class ShapeBreakingDiagnosticSuppressorTests
{
[Fact]
Expand Down
Loading