Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count16BitElements() intrinsic for SVE #94845

Closed
wants to merge 3 commits into from

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Nov 16, 2023

Extracted from #94765

For now, this is based off both #94529 and #94791

All the new code starts from 3cb75c5

For now it emits an MRS instruction. This needs updating to use an SVE CNTH, however, the codegen parts need adding alongside. Will wait until I can use the tool.

JitDumping the test program, I see the MRS

* Add encodings for SVE

* Adjust the offsets

* jit format

* fix the build for riscV64

* Address review feedback from Bruce

* Rename files to remove _

* forgot to rename file names in other places

Change-Id: I54932d16104a2582d9afc3fca6844183aa8c3536
Change-Id: Ie54c83275cced2f4fbc0f93e8cb687084547ac45
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 16, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Nov 16, 2023
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Nov 16, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Extracted from #94765

For now, this is based off both #94529 and #94791

For now it emits an MRS instruction. This needs updating to use an SVE CNTH, however, the codegen parts need adding alongside. Will wait until I can use the tool.

JitDumping the test program, I see the MRS

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, new-api-needs-documentation, community-contribution

Milestone: -

using System.Numerics;
using Xunit;

namespace JIT.HardwareIntrinsics.Arm._AdvSimd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be _Sve?

@a74nh
Copy link
Contributor Author

a74nh commented Nov 24, 2023

This needs rebasing. But still can't progress into until skeleton library files are committed.

@ghost ghost closed this Dec 24, 2023
@ghost
Copy link

ghost commented Dec 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants