Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin targets logic #18

Closed
wants to merge 9 commits into from
Closed

Begin targets logic #18

wants to merge 9 commits into from

Conversation

benvillalobos
Copy link
Member

Work Done

Created two targets, ComputeContainerConfig and PublishContainer. ComputeContainerConfig is intended to gather all info, PublishContainer is meant to do the actual work of publishing (presumably we just call a task?). ComputeContainerConfig is meant to be a "point of no return," where users should no longer modify properties/items that affect the container generation process.

Will need to coordinate more with #11 to nail down what info to grab in the targets.

Notes

I left a bunch of questions inline, this pr is expected to be a work in progress for a while.

Questions

  • Where should this targets file live?
  • Are the names of the targets okay? cc @baronfel
  • Not entirely sure if these targets should return anything. Would we ever expect an MSBuild call on a project that intends to gather info from ComputeContainerConfig?

@benvillalobos
Copy link
Member Author

benvillalobos commented Jul 5, 2022

Big win of the day: Figuring out that this is the right answer for constructing the entrypoint in self contained apps:
<ContainerEntrypoint Condition="'$(ContainerEntrypoint)' == '' and '$(SelfContained)' == 'true'">$(ContainerWorkingDirectory)/$(TargetDir)$(AssemblyName)$(_NativeExecutableExtension)</ContainerEntrypoint>

@baronfel baronfel deleted the container-targets branch August 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant