Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task and Targets #38

Closed
wants to merge 15 commits into from
Closed

Add Task and Targets #38

wants to merge 15 commits into from

Conversation

benvillalobos
Copy link
Member

#21 and #18 rebased & combined

@benvillalobos
Copy link
Member Author

Todo; add an end to end test for all the logic

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple quick things as I was poking around :)

<PackageVersion Include="MSTest.TestAdapter" Version="2.2.8" />
<PackageVersion Include="MSTest.TestFramework" Version="2.2.8" />
<PackageVersion Include="coverlet.collector" Version="3.1.2" />
<PackageVersion Include="GitHubActionsTestLogger" Version="1.4.1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should stay at 2.0.1

Layer newLayer = Layer.FromFiles(filesWithPaths.AsEnumerable());

image.AddLayer(newLayer);
image.SetEntrypoint(Entrypoint, EntrypointArgs?.Split(' ').ToArray());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll be important to document that the Entrypoint needs to be a fully-rooted path. I could see users doing something like

<ContainerEntrypoint>$(AppName)</ContainerEntrypoint>

and attempting to package up an executable at what is effectively /$(AppName), which won't exist.

Maybe there's some validation we can do here to save them: either checking that a fully-rooted path was provided, or attempting to 'root' a relative or un-rooted path against the ContainerWorkingDirectory.

@benvillalobos
Copy link
Member Author

Cloud-based note to self:

mkdir "C:\temp\dir\newproject"

dotnet new console
dotnet new nugetconfig
dotnet nuget add source "C:\temp\dir\PackageUploads" -n local-folder
dotnet build "System.Containers.Tasks"
dotnet nuget push "C:\Path\To\Nupkg" --source local-folder
dotnet add package System.Containers.Tasks
dotnet publish --publishprofile=defaultcontainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants