Add System.Containers.Tasks and CreateNewImage #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Jul 11, 2022
| <PackageVersion Include="MSTest.TestAdapter" Version="2.2.8" /> | ||
| <PackageVersion Include="MSTest.TestFramework" Version="2.2.8" /> | ||
| <PackageVersion Include="coverlet.collector" Version="3.1.2" /> | ||
| <PackageVersion Include="GitHubActionsTestLogger" Version="1.4.1" /> |
There was a problem hiding this comment.
N.B - if you bump this to at least 2.0, you get test summaries auto-generated for each CI run
There was a problem hiding this comment.
Whoops I didn't follow through on dependabot: #22.
7 tasks
Configuration for temp storage TransientTestFolder Layer.FromDirectory Validate Descriptor against schema Schemas from https://github.com/opencontainers/image-spec/tree/67d2d5658fe0476ab9bf414cec164077ebff3920/schema WIP: get an image manifest from a registry Pull image metadata and construct an image that's just a container for the JSON metadata Successfully upload blob Try uploading manifest after layer Fails with 400 `blob unknown to registry` Try to mount layer + config blobs Horrible try/catch, must remove ASAP Push overall manifest Add the layer to be pushed in test Switch to Put (which should inherently finalize) Update config on layer add Extract UploadBlob Generalize UploadBlob stream type Always upload config as blob What, should it be Linux? Switch to EnsureSuccessStatusCode Reparse JSON to get a consistent object type This is the recommended way to flatten things that * came from JSON and were parsed into a JsonObject * came from a real object and were serialized into JSON Into equivalent objects, per dotnet/runtime#64472 (comment). Extract GetClient Extract BlobAlreadyUploaded Check for blobs on image upload too Try to upload missing layers Remove redundant layer push in test Remove redundant mount of config SetEntrypoint Start local registry as part of test Still hardcoded bits but cleans up and tests the container Create and build project to pack Delete only if exists Install 6.0 SDK too Slash directions! ✊🏻 Capture stdout Make other tests more good Log more Correct app name Extract DockerRegistryManager and set it as AssemblyInit/Cleanup
Closed
|
Closing to replace with #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this up for early reviewing.