-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PingUri_ShortTimeout_Success fails 5% of the time of server #12140
Comments
@paul1956 - do you have a stack trace? |
I am reviewing the test and with 1 (millisecond) as timeout it should not throw when pinging local server. But on test server 5% of the time it takes longer than 1 millisecond. If I use a different ping API, I can see it throw every time, it fails on my local machine with a value under 900 microseconds. The easy fix is to increase timeout to a bigger number. Testing the timeout is really the responsibility of system.Net.NetworkInformation. I need to use the API with the Timeout to test VB code. I don't need to test the throw here. I will do another PR to lengthen the timeout and close the issue. |
@Tanya-Solyanik I will close when fix is merged. |
Test
Microsoft.VisualBasic.Devices.Tests.Ping_ShortTimeout_Success()
Issue description
5% of the time the test fails in the server.
The minimum timeout is 1 and sometimes the test completes before the timeout
A workaround would be to ping something other then the local machine but I would need an allowed URL.
The text was updated successfully, but these errors were encountered: