Lengthen timeout so test passes on slower servers. This fixes issue d…

…otnet#12140
paul1956 · Sep 14, 2024 · 34c49e6 · 34c49e6
1 parent 5cec4ac
commit 34c49e6
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs b/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs
@@ -12,8 +12,13 @@ public void IsAvailable()
         Assert.Equal(System.Net.NetworkInformation.NetworkInterface.GetIsNetworkAvailable(), network.IsAvailable);
     }
 
+    /// <summary>
+    /// The ping API exposed by <see cref="Network"/> is in units of Milliseconds, Pinging
+    /// local server takes approximately 1 Millisecond so there is no reliable way
+    /// to test a short timeout that for a timeout exception.
+    /// </summary>
     [Fact]
-    public void Ping_ShortTimeout_Success()
+    public void Ping_LongTimeout_Success()
     {
         Network network = new();
         network.Ping("127.0.0.1", 1).Should().BeTrue();
@@ -33,14 +38,11 @@ public void Ping_Throw()
         Assert.Throws<ArgumentNullException>(() => network.Ping((string)null));
     }
 
-    [ActiveIssue("https://github.com/dotnet/winforms/issues/12140")]
     [Fact]
-    [SkipOnArchitecture(TestArchitectures.Any,
-        "Flaky tests, see: https://github.com/dotnet/winforms/issues/12140")]
     public void PingUri_ShortTimeout_Success()
     {
         Network network = new();
-        network.Ping(new Uri("http://127.0.0.1"), 1).Should().BeTrue();
+        network.Ping(new Uri("http://127.0.0.1"), 100).Should().BeTrue();
     }
 
     [Fact]