Deprecate backend.inc in favor of a new site-process library #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k. Set uri / root in a way that allows the caller to override them.
weitzman
changed the title
weitzman
changed the title
weitzman
changed the title
weitzman
changed the title
src/Commands/core/NotifyCommands.php
Outdated
| } | ||
| // Keep backward compat and prepare a string here. | ||
| $cmd = sprintf($cmd, Escape::forSite(Drush::aliasManager()->getSelf(), $msg)); | ||
| $process = Drush::process($cmd); |
There was a problem hiding this comment.
Why not omit Escape::forSite and just:
$process = Drush::process($cmd, [$msg])?
There was a problem hiding this comment.
the 2nd argument to process() is cwd, not a replacement array. And if there were two items in the $cmd array, it would quote the first long item which is invalid I think.
There was a problem hiding this comment.
My mistake. I meant:
$process = Drush::process([$cmd, $msg]);
That will escape the commands for you. Hm, that uses Symfony escaping instead of our improved escaping. Maybe we should have Drush::process use the Escape utilities to escape all of the parameters for the local machine. Escape::shellArg() is the API to use to just escape for the local system.
greg-1-anderson
force-pushed
the
siteProcess
branch
from
648fa72
to
89a98c5
Compare
greg-1-anderson
force-pushed
the
siteProcess
branch
from
c7dd11c
to
ac61643
Compare
Reorganize test classes into subdirectories indicating their type.
sjerdo
added a commit
to sjerdo/drush
that referenced
this pull request
Aug 13, 2019
Since drush-ops#3758 syncing a database between two remote Drush 9 servers using Drush 8 seems broken. Since drush-ops#3758 the object resulted by Drush for sql dump is an array containing the path, instead of a string of the path. Server specs: Local: Drush 8 Server @A: Drush 9.7.1 Server @b: Drush 9.7.1 Command executed at server Local: drush sql-sync @A @b Result before this PR: ``` The Drush sql-dump command did not report the path to the dump file produced. Try upgrading the version of Drush you are using on the source machine. ``` Result with this fix: ``` Starting to import dump file onto Destination database. [ok] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See site-process.
See questions in the diff. Can be tested with
composer -v sut @example.live ssh -- -v -sOutput shows new and then old (proc_open) shell command:
This is nowhere near ready - we'll be hacking more at Badcamp.