-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate backend.inc in favor of a new site-process library #3758
Merged
Merged
Changes from 1 commit
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
9603c55
Rough in usage of SiteProcess
weitzman 525ff91
Put cd at end.
weitzman 354009a
Rough in handling during RedispatchHook.
weitzman fa6c708
Set minimum php to 7.1. Inject site alias manager into redispatch hoo…
greg-1-anderson f557f7e
Use site-process in sql:sync.
weitzman 61594a5
Handle ssh-wrapping with tty
greg-1-anderson dd9df38
Merge
greg-1-anderson f5ef535
sql:sync now uses site-process
weitzman d835cc5
If runner is a string, convert it to an alias record.
greg-1-anderson 7431c5b
Restore php5 compatibility
greg-1-anderson 6ea40a8
Use constraint proposed by Composer.
weitzman 92e60e4
rsync improvements, config:pull, and options_double_dash
weitzman 113ca9a
Use new Process in all the places
weitzman f748f93
Back out output formatters since its not on packagist yet
weitzman cd45601
Use hasRoot(), not empty($self->root()).
greg-1-anderson 3a59d88
Some fixes.
weitzman d36d55c
Follow the releases.
weitzman c7e8349
Return an array from cex.
weitzman a0e4a3f
Fix double dash values.
weitzman 6008e7b
Avoid a write to stdout.
weitzman 900c46e
sql:sync and site:ssh fixes.
weitzman dcee761
Add 'fields' => '*' to BackendPathEvaluator
weitzman 68514b6
[ci skip] Use UNISH_DB_URL environment variable in sut:si if it is de…
greg-1-anderson 91a954e
Fix tests
weitzman 8c5eba2
Fix up data access in BackendPathEvaluator
greg-1-anderson 930eec3
Update assertion in rsync test
greg-1-anderson 35d3ee8
Merge with Moshe's changes
greg-1-anderson d0ccd8c
[ci skip] Code style
greg-1-anderson b3d7f7e
Trim output when looking up info in sql:sync
greg-1-anderson 5d2cb3d
Fix up expectations in SqlSyncTest
greg-1-anderson 2355d46
Add real time output API and use in updatedb
weitzman 27c8d4b
UpdatedbTest fixes
weitzman 862bdcd
Lose extra text.
weitzman 42c7bf7
Fix config pull test
greg-1-anderson 38ad515
Fix handling of sql:dump path output
greg-1-anderson c88fdbe
Add Doxygen.
weitzman d9a0d28
Add doxygen and real-time to rsync.
weitzman 3cd0ad2
Use new showRealtime() method.
weitzman 4b816f6
Use ProcessBase from Consolidation.
weitzman 992d78f
Populate io()
weitzman c2af76d
Deprecate DRUSH_COMMAND in favor of "$config->get('runtime.drush.scri…
greg-1-anderson 78d9253
Remove a use statement.
weitzman f3639ac
Set an alias.
weitzman e3bab63
Fix CLI command args.
weitzman a558fc8
Do not use local path to Drush on remote calls
greg-1-anderson ae9480d
Merge branch 'siteProcess' of github.com:drush-ops/drush into sitePro…
greg-1-anderson 98fe3bd
No need for setAlias() anymore
weitzman d900eb5
Slight dedupe to updatedb log message
weitzman 3d04f8e
Up Process timeout.
weitzman e329616
Use getSelf() in sqlSync
weitzman fa633f5
Remove no longer needed calls to setIo()
weitzman 53bee38
Use new realtime output callable
weitzman bef32e2
Inject a DrushStyle into the ProcessBase's outputStyle.
greg-1-anderson 2d3dc8c
Use dev-master of consolidation/site-process for now.
greg-1-anderson 089b6cd
Try dev-master of site-alias
greg-1-anderson 257dddd
Use refactored site-process project.
greg-1-anderson ce57a63
Update to latest consolidation/site-process and fix some simulated te…
greg-1-anderson 2eef719
Fix up sql:sync test exceptions
greg-1-anderson ee2ad19
Start converting batch system - start with updatedb
weitzman a6eda48
Test fixes
weitzman 96564b6
Progress on batchTest.
weitzman b646582
Break out a UnitBatchOperations class.
weitzman 49f778c
Code style (include renaming constant timeout to TIMEOUT)
greg-1-anderson e522775
updatedb tests
weitzman 9fdbee0
CS
weitzman 762a678
Use UnstructuredListData and suppress reatime stdout during batches.
weitzman 38060cf
Seat belt for empty path during sql:sync.
weitzman dcd08bf
Fix update db tests for latest site-process project.
greg-1-anderson 1a9ebeb
Rename process commands e.g. to Drush::drush for better clarity
greg-1-anderson 07266a6
Use showRealtime()->hideStdout() in _drush_backend_batch_process
greg-1-anderson 0ef648d
Rename siteProcessCommand to siteProcess.
greg-1-anderson 255f219
Make sql:sync backward compatible.
weitzman 88753cf
Fix parens and use getOutputAsJson().
weitzman cfb80f9
CS
weitzman 978709c
Fix sqlsync test
weitzman e58a950
CS
weitzman 0c4c65c
Stop --backend from eating the next argument
greg-1-anderson 10f2e9c
Remove commented code and chnge var name.
weitzman cbb37f4
Misc updates to RedispatchHook, PreflightArgs
weitzman 9277617
Fix test fails and re-enable testNonExistentCommand().
weitzman 8494a9b
Move 2 tests into a new RedispatchTest class.
weitzman 04d392e
Woops - add the file
weitzman 127f8db
CS
weitzman 4712ee6
Straighten out command name in redispatch hook
greg-1-anderson 7d4d387
Merge branch 'siteProcess' of github.com:drush-ops/drush into sitePro…
greg-1-anderson ce1766d
Deprecate core:execute. Add missing docs reference
weitzman 4a75fe7
Add deprecated notices, and update drush_start_browser().
weitzman 84a464a
Fix right version of startBrowser(), and remove stray exec().
weitzman 7ef1d9f
CS
weitzman 403b89e
Update to site-alias ^2
greg-1-anderson 7d5e3e3
Fix browser start method.
weitzman 20dbeb4
Update NotifyCommands.
weitzman 107c8f7
Update SyncViaHttpCommands.
weitzman 89a98c5
Rename drush.script in alias records to drush-script, as it already i…
greg-1-anderson 2aff75f
Improve error msg in Notify.
weitzman 2172d1d
Port a config:edit process.
weitzman 602a701
Port 2 more shell execs.
weitzman 8be7769
Use shellArg()
weitzman ac61643
Fix notify error message - cant use
weitzman 62a3b3f
Merge branch 'master' into siteProcess
weitzman 0382c22
Test reorg (#3759)
greg-1-anderson 1a0a8d0
Remove scenario from Travis for now.
greg-1-anderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not omit Escape::forSite and just:
$process = Drush::process($cmd, [$msg])
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 2nd argument to process() is cwd, not a replacement array. And if there were two items in the $cmd array, it would quote the first long item which is invalid I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake. I meant:
That will escape the commands for you. Hm, that uses Symfony escaping instead of our improved escaping. Maybe we should have Drush::process use the Escape utilities to escape all of the parameters for the local machine.
Escape::shellArg()
is the API to use to just escape for the local system.