Fix Array to string conversion in TsvFormatter.php on line 35 #3721 #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPParsley
changed the title
|
At minimum this will need to update composer.lock, Waiting for @greg-1-anderson for a code review. |
Closed
|
I updated composer.lock, but the tests are failing. See #3918. To update composer.lock here, just run |
weitzman
requested changes
Feb 28, 2019
| @@ -17,7 +17,7 @@ class BatchCommands extends DrushCommands | |||
| * | |||
| * @return \Consolidation\OutputFormatters\StructuredData\UnstructuredListData | |||
| */ | |||
| public function process($batch_id, $options = ['format' => 'json']) | |||
| public function process($batch_id, $options = ['format' => 'null']) | |||
There was a problem hiding this comment.
The caller expects JSON to be returned. See
Lines 152 to 153 in 92b2359
| @@ -37,7 +37,7 @@ | |||
| "consolidation/annotated-command": "^2.10.2", | |||
| "consolidation/config": "^1.1.0", | |||
| "consolidation/filter-via-dot-access-data": "^1", | |||
| "consolidation/output-formatters": "^3.3.1", | |||
| "consolidation/output-formatters": "^3.4", | |||
There was a problem hiding this comment.
This does look useful. After you run composer update, please commit the changes that happen in .scenario directory.
|
Drush now depends on output-formatters ^3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 3721