Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Array to string conversion in TsvFormatter.php on line 35 #3721 #3917

Closed
wants to merge 5 commits into from
Closed

Fix Array to string conversion in TsvFormatter.php on line 35 #3721 #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59e7298
Remove deprecated each()
MPParsley Mar 20, 2018
6c0dc91
Remove deprecated each()
MPParsley Mar 20, 2018
31153cb
Merge pull request #1 from drush-ops/master
MPParsley Feb 7, 2019
429fb70
Update composer.json
MPParsley Feb 7, 2019
e368972
Update BatchCommands.php
MPParsley Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"consolidation/annotated-command": "^2.10.2",
"consolidation/config": "^1.1.0",
"consolidation/filter-via-dot-access-data": "^1",
"consolidation/output-formatters": "^3.3.1",
"consolidation/output-formatters": "^3.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look useful. After you run composer update, please commit the changes that happen in .scenario directory.

"consolidation/robo": "^1.3.4",
"consolidation/site-alias": "^2.1.1",
"consolidation/site-process": "^1",
Expand Down
2 changes: 1 addition & 1 deletion src/Drupal/Commands/core/BatchCommands.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class BatchCommands extends DrushCommands
*
* @return \Consolidation\OutputFormatters\StructuredData\UnstructuredListData
*/
public function process($batch_id, $options = ['format' => 'json'])
public function process($batch_id, $options = ['format' => 'null'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller expects JSON to be returned. See

drush/includes/batch.inc

Lines 152 to 153 in 92b2359

$process->run($process->showRealtime()->hideStdout());
$result = $process->getOutputAsJson();

{
$return = drush_batch_command($batch_id);
return new UnstructuredListData($return);
Expand Down