Create export for forcing update #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/dsheedes/cd_easytime/blob/main/server/server.lua#L74C8-L74C24 It already has permissions check to avoid exploits. |
|
Sure, but I don't want to trigger it from the client since I already do perm checking in my own server side logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all sorry for the whitespace edits. (Using github desktop is better for this)
Since this is a very popular resource, I was constantly asked for adding compatibility, so I had to fork it.
This pull request creates a new export called 'forceUpdate'.
I essentialy removed part of the code inside the forceUpdate event and made it a funciton.
Without this fork, nobody is able to change the weather from the server side which is bad since some people may use other methods to check for permissions and also the event doesn't take a source param so it relies on it being called from the client 100% of the time.