Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw warning if unscaled logit is used [Resolves #508] #548

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Throw warning if unscaled logit is used [Resolves #508] #548

merged 2 commits into from
Dec 14, 2018

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Dec 6, 2018

No description provided.

jesteria
jesteria approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jesteria jesteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/triage/experiments/validate.py Outdated Show resolved Hide resolved
@jesteria @thcrock
Update src/triage/experiments/validate.py
e8bd52e 
Co-Authored-By: thcrock <tristan.h.crockett@gmail.com>
@thcrock thcrock merged commit b89fce6 into master Dec 14, 2018
@thcrock thcrock deleted the warn_if_unscaled_logit branch December 14, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesteria jesteria jesteria approved these changes

@tweddielin tweddielin tweddielin approved these changes

Assignees

@tweddielin tweddielin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thcrock @jesteria @tweddielin