Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw warning if unscaled logit is used [Resolves #508] #548

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Throw warning if unscaled logit is used [Resolves #508] #548

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
185d43e
Throw warning if unscaled logit is used [Resolves #508]
thcrock Dec 6, 2018
e8bd52e
Update src/triage/experiments/validate.py
jesteria Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/triage/experiments/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,13 @@ def _run(self, grid_config):
)
)
for classpath, parameter_config in grid_config.items():
if classpath == "sklearn.linear_model.LogisticRegression":
logging.warning(
"sklearn.linear_model.LogisticRegression found in grid. "
"This is unscaled and not well-suited for Triage experiments. "
"Use triage.component.catwalk.estimators.classifiers.ScaledLogisticRegression "
" instead"
thcrock marked this conversation as resolved.
Show resolved Hide resolved
)
try:
module_name, class_name = classpath.rsplit(".", 1)
module = importlib.import_module(module_name)
Expand Down