-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble Square Root Updater #669
Conversation
…er into compliance with style guidelines.
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 94.55% 94.56% +0.01%
==========================================
Files 168 168
Lines 8441 8459 +18
Branches 1633 1634 +1
==========================================
+ Hits 7981 7999 +18
Misses 343 343
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -118,19 +114,18 @@ def predict_measurement(self, predicted_state, measurement_model=None, | |||
measurement_model : :class:`~.MeasurementModel` | |||
The measurement model. If omitted, the model in the updater object | |||
is used | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the blank lines are required, as they are breaking formatting in some places.
It should be noted that this pull request now includes the changes outlined in the discussion of Issue #668. This include changes to numerous |
Here is my implementation of the Ensemble Square Root filter Updater which I presented at last year's Fusion Conference.
A full writeup of the algorithm itself, as well as design philosophy can be found in my paper titled "Implementation of Ensemble Kalman Filters in Stone Soup". The contribution here (in this particular pull request) is specifically a new updater. The predictor of the EnKF and EnSRF are shared, but the EnSRF assimilates measurements without adding noise which typically results in lower sampling error and thus higher accuracy.
One other thing to note. Is that this pull request also fixes issue #668 which caused both the
EnsemblePredictor
and thepredict_measurement
method in the EnKF (the latter of which is inherited by the EnSRF).