Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate from heroku to fly.io issue #45 #46

Merged
merged 10 commits into from
Nov 18, 2022
Merged

PR: Migrate from heroku to fly.io issue #45 #46

merged 10 commits into from
Nov 18, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Nov 17, 2022 •
edited
Loading

@nelsonic nelsonic mentioned this pull request Nov 17, 2022
Closed
4 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #46 (b2b5f95) into main (5c08590) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           15        13    -2     
=========================================
- Hits            15        13    -2
Impacted Files Coverage Δ
lib/app_web/controllers/page_controller.ex 100.00% <ø> (ø)
lib/app_web/router.ex 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic
Copy link
Member Author

@SimonLab should be a quick one to review as mostly deployment (Fly.io) boilerplate code. 🤞
Thanks. 🙏

nelsonic
nelsonic commented Nov 17, 2022
View reviewed changes
Copy link
Member Author

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😜

@nelsonic nelsonic changed the title Migrate from heroku to fly.io issue #45 PR: Migrate from heroku to fly.io issue #45 Nov 17, 2022
@nelsonic nelsonic mentioned this pull request Nov 17, 2022
Closed
SimonLab
SimonLab previously approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy files looks good, thanks 👍

@SimonLab
Copy link
Member

Just noticed the merge conflicts:
image

@nelsonic
Copy link
Member Author

Merge conflicts resolved. 👌

@SimonLab
Copy link
Member

I think we can also run mix deps.clean --unused --unlock to remove deleted dependencies

https://hexdocs.pm/mix/1.12/Mix.Tasks.Deps.Clean.html

@nelsonic
Copy link
Member Author

Good call. Done. ✅

@SimonLab SimonLab merged commit e4229f0 into main Nov 18, 2022
@SimonLab SimonLab deleted the migrate-from-heroku-to-fly.io-issue-#45 branch November 18, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review chore enhancement New feature or request priority-2 T25m technical
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab