-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plug dependency might be a blocker when importing auth_plug in new projects #76
Comments
@LuchoTurtle thank you very much for opening this issue. ✅ |
@LuchoTurtle please try: 1.4.15 Oct 13, 2022 🙏 |
Package published to https://hex.pm/packages/auth_plug/1.4.16 📦 |
Thank you for the updates but it doesn't seem that downgrading the
|
Man this is annoying. Please |
Forking the repos is fine ... But it's much easier to collaborate if you create a branch on the original repo and push your changes up to GitHub. 🤞 |
I've lowered the required version of Didn't wan to go below that as 1.13.1 and 1.13.0 were both retired (so might have bugs) and 1.12.1 is ancient at this point. 💭 |
Of course! We oughta have all of these updated, can't rely on old code! Here's the branch so you can clone -> https://github.com/dwyl/phoenix-chat-example/tree/add-auth I commented the line you ought to change so you can run |
Definitely going to take a look at this next. But working on dwyl/mvp#165 for now. ⏳ |
…ompatibility-issue#76 PR: Downgrade plug version for phoenix compatibility issue #76
Should be working as expected with the latest |
As shown in dwyl/phoenix-liveview-realtime-cursor-tracking-tutorial#12 (comment), Closing 👍 |
Thanks for confirming. 👌 |
I was trying to use this plug in a fork repo of Phoenix Chat App and I can't seem to be able to run
mix deps.get
properly with the latest version (1.4.14).The repo I'm trying to import this into has all its dependencies updated, which makes this situation awfully weird.
The error seems to stem from the
plug
dependency this package is using. It's the latest version but apparently other packages that I have constraint theplug
versions I have between1.10.2
to1.13.3
.If we downgrade the
plug
dependency on this package to1.13.13
(instead of1.13.14
), it should work, right?Fixing this will probably fix #75 .
The text was updated successfully, but these errors were encountered: