-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Add auth #12
[PR] Add auth #12
Conversation
After logging in, I can't seem to get access to the socket assigns pertaining to the logged-in user. Will further look into this tomorrow, during/after standup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nelsonic
Gonna have a look at this https://github.com/dwyl/mvp/blob/main/BUILDIT.md#62-create-auth-controller |
@nelsonic the auth tests are failing because there's no The PR is ready and the auth works properly now. |
We don't have any org-wide |
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 22 35 +13
=========================================
+ Hits 22 35 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pending review/merge of: dwyl/auth_plug#88 |
Made the changes to use Should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuchoTurtle looks great! Thanks. 👌
closes #1
This PR adds authentication using https://github.com/dwyl/auth_plug.
Instead of usernames being randomly generated and assigned, when a user logs in, his username is shown.