Chore: Tidy Drag & Drop Code for Consistency

[nelsonic]

At present the code in assets/js/app.js, lib/app_web/live/app_live.html.heex and lib/app_web/live/app_live.ex has inconsistent naming of events and variables ... 🙃

e.g:

mvp/assets/js/app.js

Lines 35 to 58 in a7408a1

	this.el.addEventListener("remove-highlight", e => {
	hook.pushEventTo("#items", "removeHighlight", {id: e.detail.id})
	// console.log('remove-highlight', e.detail.id)
	})
	this.el.addEventListener("dragoverItem", e => {
	// console.log("dragoverItem", e.detail)
	const currentItemId = e.detail.currentItem.id
	const selectedItemId = e.detail.selectedItemId
	if( currentItemId != selectedItemId) {
	hook.pushEventTo("#items", "dragoverItem", {currentItemId: currentItemId, selectedItemId: selectedItemId})
	itemId_to = e.detail.currentItem.dataset.id
	}
	})
	this.el.addEventListener("update-indexes", e => {
	const item_id = e.detail.fromItemId
	const list_ids = get_list_item_cids()
	console.log("update-indexes", e.detail, "list: ", list_ids)
	// Check if both "from" and "to" are defined
	if(item_id && itemId_to && item_id != itemId_to) {
	hook.pushEventTo("#items", "update_list_seq",
	{seq: list_ids})
	}

"remove-highlight" should be "remove_highlight" and "dragoverItem" should be "dragover_item" for consistency.

Todo

• Review all the code in these files and the corresponding tests test/app_web/live/app_live_test.exs and update for consistency. 👩‍💻
• Ensure that all tests still pass and functionality still works. ✅
• Create PR and assign for review.

[LuchoTurtle]

I can open a small PR over the weekend 👌

[nelsonic]

PR: #419 merged. ✅
Thanks @LuchoTurtle 👌