Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Making variables "snake_case" in drag and drop code #419

Merged
merged 5 commits into from
Sep 16, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #416

This renames events and variables in assets/js/app.js, lib/app_web/live/app_live.ex and lib/app_web/live/app_live.html.heex, as well as the respective tests.

BUILDIT.md has also been modified according to these changes.

@LuchoTurtle LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person chore a tedious but necessary task often paying technical debt labels Sep 9, 2023
@LuchoTurtle LuchoTurtle self-assigned this Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #419 (f3c1d4a) into main (b8aee0e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          599       599           
=========================================
  Hits           599       599           
Files Changed Coverage Δ
lib/app_web/live/app_live.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

LuchoTurtle commented Sep 9, 2023

Should be mergeable 🆗

@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Sep 9, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Sep 9, 2023
BUILDIT.md Outdated Show resolved Hide resolved
@nelsonic
Copy link
Member

Hi @LuchoTurtle the only reason I didn't merge this immediately is that it will create merge-conflicts on the #165 PR I'm trying to finish. Not ignoring it. promise.

@nelsonic nelsonic changed the base branch from main to items-list September 16, 2023 08:52
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the target branch to items-list and confirmed no merge-conflicts. ✅
Thanks again for updating the variable names. 🙏
Merging. :shipit:

@nelsonic nelsonic merged commit d70ea74 into items-list Sep 16, 2023
3 checks passed
@nelsonic nelsonic deleted the variable_consistency#416 branch September 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Tidy Drag & Drop Code for Consistency
2 participants