[PR] Edit timer

[LuchoTurtle]

Should close #195

Still a work in progress. The user when editing an item will see a list of timers that he can edit.

[LuchoTurtle]

Even though this feature should be and is super simple to implement, I'm getting the go around implementing proper form validation and getting updated structs from the LiveView to the Phoenix server so I can update timers with their IDs.

This shouldn't be hard but it's weird because the way form is implemented when editing an item should also work on this occasion but I'm getting 0 events in the Phoenix server 😞 .

I'll keep trying

[nelsonic]

@LuchoTurtle thanks for opening this PR to track/share your progress! 🎉
Don’t worry about something not working first time. That’s normal. Just keep sharing your progress/frustrations and if you hit a brick wall, give as much detail as possible so one of us can help you figure it out. 👌

[LuchoTurtle]

Slow progress so far, from the user story perspective. Since I was practically obliged to use Bluzkly's datetime parser gist (even more so if we are in the future wanting to accommodate other formats), since I was stuck with sending error feedback from the server to the form, I tried to focus on testing what I had done.

Since I have to test this parser, I had to battle a bit with VSCode to try and get debugging working but I never did (got this The database for App.Repo couldn't be dropped: ERROR 55006 (object_in_use) database "app_test" is being accessed by other users error), so I've just been Logger.debuging my way through. It's taking a lot more than expected, it's hard to get code coverage on edge cases...

[nelsonic]

Please don't worry about things taking longer than you expected. ⏳
Just stay focussed on learning, capturing your learning 📝
and the feature will be a byproduct of that learning. 🪄
Very few companies/orgs think this way; we do! 👌
remember Logger.debug --> dbg/1

If you want to remote pair on anything please LMK (I'm always available!) 👨‍💻
But equally I understand the merits of "figuring it out for yourself" ... 😉

[LuchoTurtle]

Just finished all possible test coverage. The two lines that are missing relate to the final stretch: feedback to user and a peculiar situation that happens when I broadcast the new items list to the rest of the users. The timer form appears to duplicate after broadcasting 🤔

[nelsonic]

Editing times is mostly working for me but I occasionally get these errors:

[error] GenServer #PID<0.722.0> terminating
** (FunctionClauseError) no function clause matching in NaiveDateTime.compare/2
    (elixir 1.14.1) lib/calendar/naive_datetime.ex:1025: NaiveDateTime.compare(~N[2022-11-16 17:21:07], nil)
    (app 1.0.0) lib/app/timer.ex:205: anonymous fn/4 in App.Timer.update_timer_inside_changeset_list/3
    (elixir 1.14.1) lib/enum.ex:2468: Enum."-reduce/3-lists^foldl/2-0-"/3
    (app 1.0.0) lib/app/timer.ex:199: App.Timer.update_timer_inside_changeset_list/3
    (app 1.0.0) lib/app_web/live/app_live.ex:143: AppWeb.AppLive.handle_event/3
    (phoenix_live_view 0.18.2) lib/phoenix_live_view/channel.ex:382: anonymous fn/3 in Phoenix.LiveView.Channel.view_handle_event/3
    (telemetry 1.1.0) /mvp/deps/telemetry/src/telemetry.erl:320: :telemetry.span/3
    (phoenix_live_view 0.18.2) lib/phoenix_live_view/channel.ex:216: Phoenix.LiveView.Channel.handle_info/2
    (stdlib 4.1.1) gen_server.erl:1123: :gen_server.try_dispatch/4
    (stdlib 4.1.1) gen_server.erl:1200: :gen_server.handle_msg/6
    (stdlib 4.1.1) proc_lib.erl:240: :proc_lib.init_p_do_apply/3

The UI does not display an error and everything appears to continue working.
So from the person using the App's perspective it appears to work. 👌
Just want to make sure this error condition doesn't get committed to main and then we end up with tech-debt to pay. 💭

[nelsonic]

Thanks for taking a look at this. 👌

[LuchoTurtle]

I pushed the tests to 100% coverage @nelsonic . It seems this commit broke some auth tests :/

[nelsonic]

Thanks for making these update @LuchoTurtle 👌
Edit Timer MVP Looking good. Might require some UI/UX iteration. 💭
But let's get some feedback from @iteles & @Stephanymtr ASAP.

[nelsonic]

Working in prod: https://mvp.fly.dev 🚀

Thanks again @LuchoTurtle 🙌