Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Edit timer #196

Merged
merged 55 commits into from
Nov 22, 2022
Merged

[PR] Edit timer #196

merged 55 commits into from
Nov 22, 2022

Commits on Oct 27, 2022

  1. feat: Example UI done.

    @LuchoTurtle
    LuchoTurtle committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e3b9165 View commit details
    Browse the repository at this point in the history

  2. feat: Adding timer field to item when fetching.

    @LuchoTurtle
    LuchoTurtle committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    38e4e32 View commit details
    Browse the repository at this point in the history

  3. fix: Removing nil timers.

    @LuchoTurtle
    LuchoTurtle committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8606526 View commit details
    Browse the repository at this point in the history

  4. fix: Returning truncated format to LIveview.

    @LuchoTurtle
    LuchoTurtle committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cdae413 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. feat: Finally passing data to server.

    @LuchoTurtle
    LuchoTurtle committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    57f7911 View commit details
    Browse the repository at this point in the history

  2. feat: Updating timer info on repo. Fixing IDs. 

    Adding parser and error handling. Broadcasting doesn't work properly.
    @LuchoTurtle
    LuchoTurtle committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    3556726 View commit details
    Browse the repository at this point in the history

  3. fix: Fixing when no timers are found.

    @LuchoTurtle
    LuchoTurtle committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    9fefc71 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. fix: Error handling and fixing format issues on CI.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5c0a97d View commit details
    Browse the repository at this point in the history

  2. fix: Fixing formatting errors.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    7cb2e9b View commit details
    Browse the repository at this point in the history

  3. feat: Adding tests for DateTimeParser.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    233b6de View commit details
    Browse the repository at this point in the history

  4. feat: Increasing code coverage. 

    The missing two lines are dependent on the feedback to the form and broadcast of information.
    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    c242dfd View commit details
    Browse the repository at this point in the history

  5. feat: Adding docs to DateTimeParser.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    909918b View commit details
    Browse the repository at this point in the history

  6. fix: Formatting test files.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    38c0d42 View commit details
    Browse the repository at this point in the history

  7. fix: Fixing test.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    24d15f9 View commit details
    Browse the repository at this point in the history

  8. fix: Fixing unwanted commit.

    @LuchoTurtle
    LuchoTurtle committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    684101c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. fix: Fixing broadcast bug.

    @LuchoTurtle
    LuchoTurtle committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ffd1c72 View commit details
    Browse the repository at this point in the history

  2. fix: Fixing introduced bug on saving item. 

    Mistakenly changed the event name instead of the id of the form.
    @LuchoTurtle
    LuchoTurtle committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ecc2ef5 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. feat: Updating BUILD.MD.

    @LuchoTurtle
    LuchoTurtle committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    c1fd3ea View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. feat: Adding timer changeset array to socket assigns and erroring thr… 

    …ough index.
    @LuchoTurtle
    LuchoTurtle committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    17ca24b View commit details
    Browse the repository at this point in the history

  2. feat: Removing unnecessary list of timers when fetching items on mount. 

    The timers are fetched ad-hoc when editing an item.
    @LuchoTurtle
    LuchoTurtle committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    211a93c View commit details
    Browse the repository at this point in the history

  3. fix: Fixing duplicate form when error occurs. 

    https://elixirforum.com/t/i-had-the-weirdest-problem-with-liveviews-change-tracking-when-name-attribute-has-value-id/39008/3
    @LuchoTurtle
    LuchoTurtle committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    45df2a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. feat: Creating method to error out timer changeset.

    @LuchoTurtle
    LuchoTurtle committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    db5e040 View commit details
    Browse the repository at this point in the history

  2. fix: Fixing tests.

    @LuchoTurtle
    LuchoTurtle committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    8b09799 View commit details
    Browse the repository at this point in the history

  3. feat: Add remaining update tests.

    @LuchoTurtle
    LuchoTurtle committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    b255561 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'array_of_changesets' into edit-timer

    @LuchoTurtle
    LuchoTurtle committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    d0789f4 View commit details
    Browse the repository at this point in the history

  5. fix: Fixing format.

    @LuchoTurtle
    LuchoTurtle committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    b538b86 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. feat: Updating timer.

    @LuchoTurtle
    LuchoTurtle committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d8360f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. fix: Fixing warnings.

    @LuchoTurtle
    LuchoTurtle committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    2642334 View commit details
    Browse the repository at this point in the history

  2. fix: Format code.

    @LuchoTurtle
    LuchoTurtle committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d601dc0 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. update table of contents in BUILDIT.md as per #196 (comment)

    @nelsonic
    nelsonic committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    0f0b813 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. fix: Errors are cleared on another submit. #195.

    @LuchoTurtle
    LuchoTurtle committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e125fae View commit details
    Browse the repository at this point in the history

  2. feat: Checking if timer being edited overlaps with others #195

    @LuchoTurtle
    LuchoTurtle committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    2f9bc89 View commit details
    Browse the repository at this point in the history

  3. fix: Uncommenting update timer line.

    @LuchoTurtle
    LuchoTurtle committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d2c2b91 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. fix: Editing timers while running works properly. #195 

    The timer can be updated while it is running. Validation now works properly.
    @LuchoTurtle
    LuchoTurtle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    ac53751 View commit details
    Browse the repository at this point in the history

  2. feat: Adding tests to test behaviour when editing timers. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1bcdaca View commit details
    Browse the repository at this point in the history

  3. fix: Formatting files. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    76c0a50 View commit details
    Browse the repository at this point in the history

  4. fix: Fixing auth test. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b2171d7 View commit details
    Browse the repository at this point in the history

  5. fix: Format test file.

    @LuchoTurtle
    LuchoTurtle committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    356d69a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. fix: Deleting parser in favour of using Timex.

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    8d7a449 View commit details
    Browse the repository at this point in the history

  2. fix: Refactoring erroring timer changeset to Timer file.

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    be0ba43 View commit details
    Browse the repository at this point in the history

  3. fix: Refactoring changeset code to timer.ex.

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5f70ee9 View commit details
    Browse the repository at this point in the history

  4. fix: Refactoring erroring changeset in Timer.ex. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    0e5a49e View commit details
    Browse the repository at this point in the history

  5. fix: Fixing tests on ongoing timers and refactoring to Timer.ex. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6536a5f View commit details
    Browse the repository at this point in the history

  6. fix: Adding documentation and simplifying controller pattern matching… 

    … on error. #195
    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    71d2f4e View commit details
    Browse the repository at this point in the history

  7. fix: Updating BUILD.md file. #195

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    1b62bd7 View commit details
    Browse the repository at this point in the history

  8. fix: Formatting files.

    @LuchoTurtle
    LuchoTurtle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    10f400b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. fix: Commenting adding Timex as dependency. 

    Co-authored-by: Nelson <194400+nelsonic@users.noreply.github.com>
    @LuchoTurtle @nelsonic
    LuchoTurtle and nelsonic authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    358d85a View commit details
    Browse the repository at this point in the history

  2. fix: Fixing test warning on "handle_info/2 update with editing open". 

    The assertion was an assignment, not a comparison.
    @LuchoTurtle
    LuchoTurtle committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    71592db View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/edit-timer' into edit-timer

    @LuchoTurtle
    LuchoTurtle committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e4b7f4c View commit details
    Browse the repository at this point in the history

  4. fix: Pattern matching on update_timer_inside_changeset_list. 

    Passing a timer object and pattern match on function to make it more readable.
    @LuchoTurtle
    LuchoTurtle committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    60ede76 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. fix: Fixing editing historical timer while there is an ongoing timer.

    @LuchoTurtle
    LuchoTurtle committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    677f68d View commit details
    Browse the repository at this point in the history

  2. fix: Formatting files.

    @LuchoTurtle
    LuchoTurtle committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    042a6ce View commit details
    Browse the repository at this point in the history

  3. fix: Updating BUILD.md file.

    @LuchoTurtle
    LuchoTurtle committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    8225674 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. fix: Fix tests for 100% coverage.

    @LuchoTurtle
    LuchoTurtle committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    53b7de6 View commit details
    Browse the repository at this point in the history

  2. remove "environment: dwylauth" from ci.yml

    @nelsonic
    nelsonic authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    38b26ae View commit details
    Browse the repository at this point in the history