[19576] Updatable disable_positive_acks period (backport #3879) #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #19576: Test Update positive_acks period on RTPS Layer Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19567: Fix Update positive_acks period on RTPS Layer Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: Test Update positive_acks period on DDS Layer Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: Fix ack_timer and Updatability of positive_acks on DDS Layer Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: Uncrustify fix Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: Fix linux ci Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Ref #19576: DataReaderImpl update and updateAttributes call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: Fix mac-ci Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #19576: move if clause Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit b84825a)
12 tasks
|
@richiprosima please test this |
JLBuenoLopez
added
needs-review
cferreiragonz
previously approved these changes
Oct 3, 2023
|
@richiprosima please test this |
|
Cherry picking the merge commit of #3915 needed |
* Refs #19687. Add regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19687. Rename argument. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19687. Refactor on DataWriterImpl::set_qos. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
@richiprosima Please test this |
|
@richiprosima please test mac |
|
Mac failure seems unrelated. |
JLBuenoLopez
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3879 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com