Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19576] Updatable disable_positive_acks period (backport #3879) #3895

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[19576] Updatable disable_positive_acks period (backport #3879) #3895

merged 3 commits into from
Oct 26, 2023

Commits on Oct 2, 2023

  1. Updatable disable_positive_acks period (#3879) 

    * Refs #19576: Test Update positive_acks period on RTPS Layer

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19567: Fix Update positive_acks period on RTPS Layer

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: Test Update positive_acks period on DDS Layer

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: Fix ack_timer and Updatability of positive_acks on DDS Layer

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: Uncrustify fix

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: Fix linux ci

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Ref #19576: DataReaderImpl update and updateAttributes call

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: Fix mac-ci

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #19576: move if clause

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit b84825a)
    @cferreiragonz @mergify
    cferreiragonz authored and mergify[bot] committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    9566133 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Fix updatability of immutable DataWriterQos (#3915) 

    * Refs #19687. Add regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19687. Rename argument.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19687. Refactor on DataWriterImpl::set_qos.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1a57342 View commit details
    Browse the repository at this point in the history

  2. Fix build after rebase 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    254deaf View commit details
    Browse the repository at this point in the history