[20438] LARGE_DATA Participants logic with same listening ports

[cferreiragonz]

Description

This feature adds support for the unlikely case in which two participants configured with the LARGE_DATA builtin transports obtain randomly the same listening port. This case can only occur if the participants are located in different hosts and, thus, each of them has a different IP address.
Due to the logic implemented in the channel negotiation of the LARGE_DATA topology, unnecessary channels might be created if this case occurs, which will be addressed in the future.

@Mergifyio backport 2.12.x 2.10.x 2.6.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• [N/A] Any new/modified methods have been properly documented using Doxygen.
• Changes are ABI compatible.
• Changes are API compatible.
• [N/A] New feature has been added to the versions.md file (if applicable).
• [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[JesusPoderoso]

@richiprosima please test this

[JesusPoderoso]

It seems there are build issues only on Windows @cferreiragonz. Can you address them, please?

D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(775,40): error C2059: syntax error: '<class-head>' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(776,13): error C2143: syntax error: missing ';' before '{' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,48): error C2332: 'struct': missing tag name [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,48): error C2143: syntax error: missing ')' before '.' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,48): error C3484: syntax error: expected '->' before the return type [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,49): error C3613: missing return type after '->' ('int' assumed) [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,49): error C3646: 'locator': unknown override specifier [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,56): error C2059: syntax error: ')' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(777,57): error C3551: if a trailing return type is used then the leading return type shall be the single type-specifier 'auto' (not 'eprosima::fastdds::rtps::Locator') [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(779,20): error C2664: 'bool eprosima::fastdds::rtps::TCPTransportInterface::is_interface_allowed(const eprosima::fastdds::rtps::Locator &) const': cannot convert argument 1 from 'eprosima::fastdds::rtps::Locator (__cdecl *)(,)' to 'const eprosima::fastdds::rtps::Locator &' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(779,20): message : Reason: cannot convert from 'overloaded-function' to 'const eprosima::fastdds::rtps::Locator' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(779,20): message : No constructor could take the source type, or constructor overload resolution was ambiguous [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.h(288,18): message : see declaration of 'eprosima::fastdds::rtps::TCPTransportInterface::is_interface_allowed' (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp) [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(781,49): error C2664: 'void std::vector<eprosima::fastrtps::rtps::Locator_t,std::allocator<eprosima::fastrtps::rtps::Locator_t>>::push_back(const _Ty &)': cannot convert argument 1 from 'eprosima::fastdds::rtps::Locator (__cdecl *)(,)' to 'const _Ty &' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
            with
            [
                _Ty=eprosima::fastrtps::rtps::Locator_t
            ]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(781,49): message : Reason: cannot convert from 'overloaded-function' to 'const _Ty' [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
            with
            [
                _Ty=eprosima::fastrtps::rtps::Locator_t
            ]
  D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp(781,49): message : No constructor could take the source type, or constructor overload resolution was ambiguous [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vector(742,33): message : see declaration of 'std::vector<eprosima::fastrtps::rtps::Locator_t,std::allocator<eprosima::fastrtps::rtps::Locator_t>>::push_back' (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastrtps\src\cpp\rtps\transport\TCPTransportInterface.cpp) [D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\unittest\rtps\network\NetworkFactoryTests.vcxproj]

[JesusPoderoso]

@richiprosima please test this

[JesusPoderoso]

@Mergifyio rebase

[mergify]

rebase

☑️ Nothing to do

• -conflict [📌 rebase requirement]
• -closed [📌 rebase requirement]

[cferreiragonz]

@richiprosima please test this

[EduPonz]

@Mergifyio backport 2.12.x 2.10.x 2.6.x

[mergify]

backport 2.12.x 2.10.x 2.6.x

✅ Backports have been created

• #4432 [20438] LARGE_DATA Participants logic with same listening ports (backport #4396) has been created for branch 2.12.x but encountered conflicts
• #4433 [20438] LARGE_DATA Participants logic with same listening ports (backport #4396) has been created for branch 2.10.x but encountered conflicts
• #4434 [20438] LARGE_DATA Participants logic with same listening ports (backport #4396) has been created for branch 2.6.x but encountered conflicts