Adapt SwDD for authorization #346
Open
+316
−604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue-Id: #22
inf17101
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I suggest to describe the Authorizer object in the design decisions at the top of this README and then using the tag -Authorizer in the swdds.
Next, the swdd swdd~agent-compares-control-interface-metadata~1, which I have created within the refactoring of ControlInterface PR #345, must be extended to include the comparison of the Authorizers (it is compared when updating a workload according to swdd~agent-workload-obj-update-command~1). This is because the previous Authorization PR #22 has made changes inside the workload.rs update logic.
There was a problem hiding this comment.
I have made the requested changes.
Issue-Id: #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.