-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt SwDD for authorization #346
Open
christoph-hamm
wants to merge
10
commits into
main
Choose a base branch
from
22_swdd_for_authorization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d4152ad
Remove unused keywords from stest resources
christoph-hamm 5bbb05b
Add Authorizer to structural view of the agent
christoph-hamm 9d856d0
Add requirements for authorization
christoph-hamm 985375e
Add version to control_interface_tester
christoph-hamm ec513cc
Add test coverage for authorization requirements
christoph-hamm 1d9d9fe
Merge branch 'main' into 22_swdd_for_authorization
christoph-hamm cbf8c8e
Add description of Authorizer to Structural View of agent
christoph-hamm 3af48b7
Use Authorizer instead of Authorization as tag in agent SWDD
christoph-hamm 8693b8c
Merge image forgotten in last merge
christoph-hamm 707e233
Include authorizer in requirement for control interface change
christoph-hamm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to describe the
Authorizer
object in the design decisions at the top of this README and then using the tag-Authorizer
in the swdds.Next, the swdd
swdd~agent-compares-control-interface-metadata~1
, which I have created within the refactoring of ControlInterface PR #345, must be extended to include the comparison of theAuthorizer
s (it is compared when updating a workload according toswdd~agent-workload-obj-update-command~1
). This is because the previous Authorization PR #22 has made changes inside the workload.rs update logic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the requested changes.