Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Tycho in eclipse-cbi-plugin #542

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Sep 12, 2024

Currently the plugin relies on some of Tycho components and classes this has the risk of breakage and incompatibility.

This do the following

  • drop generate-api-build-xml mojo, if it is useful for anyone it should be migrated to Tycho
  • remove Tycho dependency
  • embed relevant portions of Tycho code that are actually used here

As a background, we are currently migrate Tycho to Maven 4 and therefore changing some internals to prepare for this step. This has suddenly break the mojo for unknown reasons see for example:

https://github.com/eclipse-tycho/tycho/actions/runs/10814711934/job/30001836975

Error:  Failed to execute goal org.eclipse.cbi.maven.plugins:eclipse-cbi-plugin:1.5.0:plugin-versions (plugin-versions) on project eclipse-junit-tests: Execution plugin-versions of goal org.eclipse.cbi.maven.plugins:eclipse-cbi-plugin:1.5.0:plugin-versions failed: Unable to load the mojo 'plugin-versions' (or one of its required components) from the plugin 'org.eclipse.cbi.maven.plugins:eclipse-cbi-plugin:1.5.0': java.util.NoSuchElementException
Error:        role: org.apache.maven.plugin.Mojo
Error:    roleHint: org.eclipse.cbi.maven.plugins:eclipse-cbi-plugin:1.5.0:plugin-versions
Error:  -> [Help 1]

Currently the plugin relies on some of Tycho components and classes this
has the risk of breakage and incompatibility.

This do the following
- drop generate-api-build-xml mojo, if it is useful for anyone it should
be migrated to Tycho
- remove Tycho dependency
- embed relevant portions of Tycho code that are actually used here
@laeubi laeubi force-pushed the do_not_use_tycho_in_cbi_plugin branch from 921ff2e to 8b64d71 Compare September 12, 2024 04:19
@akurtakov
Copy link
Contributor

I'm merging this one now as we have to keep progressing on Tycho/Platform side.

@akurtakov
Copy link
Contributor

@laeubi Would you please switch platform build to used 1.5.1-SNAPSHOT? If/when this is proved to not cause issues we should ask @fredg02 / @mbarbero for a release.

@akurtakov akurtakov merged commit 9cbb05c into eclipse-cbi:main Sep 19, 2024
7 checks passed
@akurtakov
Copy link
Contributor

@fredg02 @mbarbero Would you please release version 1.5.1 of cbi plugins? This is needed so Platform build doesn't use snapshot of cbi-plugin/jarsigner. The change to not require Tycho in org.eclipse.cbi.plugin is purely internal so no need for minor version bump IMO.

@mbarbero
Copy link
Member

1.5.2 has been released (no 1.5.1 as there has been a quirk during release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants