Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swt verification build #4295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Sep 24, 2024

This will hopefully catch some issues earlier in the future.

FYI @HeikoKlare

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Sep 24, 2024
@laeubi laeubi force-pushed the add_swt_verification_build branch 5 times, most recently from 9147fbc to bdcec68 Compare September 24, 2024 08:33
@laeubi
Copy link
Member Author

laeubi commented Sep 24, 2024

@HeikoKlare for some reason the SWT build succeeds here so do I need to enable something special?

@HeikoKlare
Copy link
Contributor

The build succeeds, but when looking at the logs it does not seem to do anything meaningful. It seem to fail at some early point of execution without making it the action fail, doesn't it? I cannot see any information about bundles being compiled. But I also cannot tell what's wrong with the actions specification so that the action is not executed properly.

Even if that was fixed, the build may succeed because it's only executed on Linux. For some reasons the GH actions Linux build for SWT currently succeeds. Only the MacOS builds are affected. As you guessed, this may be for reasons of ordering. So if we want to have that additional workflow fail for the current issue in SWT, we would probably have to make it a Matrix build also being executed on MacOS.

@laeubi
Copy link
Member Author

laeubi commented Sep 24, 2024

The build succeeds, but when looking at the logs it does not seem to do anything meaningful.

I enabled the test and now something is borked, before it run without a problem :-\

Even if that was fixed, the build may succeed because it's only executed on Linux. For some reasons the GH actions Linux build for SWT currently succeeds. Only the MacOS builds are affected.

Good point, it seems I need to setup a matrix-build for this case.

@HeikoKlare
Copy link
Contributor

I am not familiar with the existing verification builds, but taking a look at logs of the existing ones, they do also not provide reasonable information about the Maven build / indicate a proper execution of the Maven build. Is this intended/expected or may there be some issue with these verification builds overall?
For example, the Eclipse Platform Individual Bundles Build has similar logs. I took at look at, e.g., this build from some days ago: https://github.com/eclipse-tycho/tycho/actions/runs/10935901809/job/30358488371

@laeubi
Copy link
Member Author

laeubi commented Sep 24, 2024

Is this intended/expected or may there be some issue with these verification builds overall?

Actually it should look like a usual maven build ... seems I need to take a look but can't spot anything obvious the log looks like the process just terminates somehow.

@laeubi
Copy link
Member Author

laeubi commented Sep 24, 2024

Copy link

github-actions bot commented Sep 24, 2024

Test Results

  603 files    603 suites   4h 28m 36s ⏱️
  430 tests   421 ✅  7 💤 0 ❌ 2 🔥
1 290 runs  1 266 ✅ 22 💤 0 ❌ 2 🔥

For more details on these errors, see this check.

Results for commit cb3dc44.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor

If I see correctly, the first verification build (Verify Eclipse Platform Aggregator Build) seems to work fine, while the existing second (Verify Eclipse Platform Individual Bundles Build) and the one contributed in this PR do not run as expected. The only real difference I see is in the configuration of the toolchain and settings files for that build, though I am not sure whether them being missing may cause the issues:

--global-toolchains ${{ github.workspace }}/tycho/.github/toolchains.xml

--settings ${{ github.workspace }}/tycho/.github/settings.xml

@akurtakov
Copy link
Member

At least the ibuild looks fine, except the usual failure due to the CBI plugin:

* https://github.com/eclipse-tycho/tycho/actions/runs/11010139398/job/30571375964?pr=4295

This one is fine now.

@laeubi laeubi force-pushed the add_swt_verification_build branch 2 times, most recently from 0f70a4e to 557d161 Compare October 7, 2024 14:04
@laeubi
Copy link
Member Author

laeubi commented Oct 7, 2024

I now added a matrix for the SWT test lets see what happens.

@laeubi laeubi force-pushed the add_swt_verification_build branch 2 times, most recently from 974824c to 5ddc04c Compare October 7, 2024 15:19
@laeubi
Copy link
Member Author

laeubi commented Oct 7, 2024

Okay now windows can't evaluate the shell expression to find the Maven version

mvn -ntp --batch-mode -Pbuild-individual-bundles -Pbree-libs -DskipTests -Dtycho.version=$(mvn help:evaluate -f D:\a\tycho\tycho/tycho -Dexpression=project.version -q -DforceStdout) -T1C clean verify

anyone has an idea for a cross-platform solution?!?

@merks
Copy link
Contributor

merks commented Oct 8, 2024

Are you expecting it to invoke powershell rather than sh.exe or bash.exe?

image

@laeubi
Copy link
Member Author

laeubi commented Oct 8, 2024

Are you expecting it to invoke powershell rather than sh.exe or bash.exe?

Good point I tried to configure bash as a shell explicitly now.

@laeubi
Copy link
Member Author

laeubi commented Oct 8, 2024

It is getting further but now path separators are messed up:

-Dtycho.version=$(mvn help:evaluate -f D:\a\tycho\tycho/tycho -Dexpression=project.version -q -DforceStdout)

@laeubi
Copy link
Member Author

laeubi commented Oct 8, 2024

Interestingly the Windows build now works but the aggregator build shows the compile problem ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants