Bug 580873: Remove error checking on dprintf parameters #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft because it needs:
|
jonahgraham
force-pushed
the
better_dprintf_error_handling
branch
from
323423f
to
c2473a5
Compare
jonahgraham
force-pushed
the
better_dprintf_error_handling
branch
from
c2473a5
to
05c4232
Compare
The parser for dprintf parameters was much too simplistic and prevents real uses cases from operating. It is not necessary to remove the , between the arguments to dprintf, so don't try to split on that anymore. That also means we can't check for and error on mismatch between format specifiers and number of arguments. e.g. "===> XML_EVENT_TEXT(%s)\n", (char *)strtok(Text,"\n") should be permitted. The alternative would be to write a more complete parser for both the printf specification and the arguments. Well out of scope and unnecessary. Some inputs may now be accepted by the GUI and then when inserted with GDB fail. These errors are displayed in the GUI already anyway.
jonahgraham
force-pushed
the
better_dprintf_error_handling
branch
from
05c4232
to
c4c57c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser for dprintf parameters was much too simplistic andprevents real uses cases from operating.
It is not necessary to remove the , between the arguments to dprintf, so don't try to split on that anymore. That also means we can't check for and error on mismatch between format specifiers and number of arguments.
e.g.
"===> XML_EVENT_TEXT(%s)\n", (char *)strtok(Text,"\n")should be permitted.The alternative would be to write a more complete parser for both the printf specification and the arguments. Well out of scope and unnecessary.
Some inputs may now be accepted by the GUI and then when inserted with GDB fail. These errors are displayed in the GUI already anyway.