Various cleanup work in preparation for PR #90 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 400628 was originally completed without any new tests. To make it easier to test that Bug 580873 works, this commit adds in some missing tests.
This fixes numerous warnings like this: Boolean is a value-based type which is a discouraged argument for the synchronized statement and: Integer is a value-based type which is a discouraged argument for the synchronized statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bunch of small changes in PR #90 to prepare for the fix to Bug 580873.
This PR pulls those changes out into its own PR so that #90 can be properly focussed.