Merge pull request #23992 from tnagao7/cditck-getknownclasses

Fix provider tests in CDI TCK
eclipse-ee4j · Jun 14, 2022 · ccae753 · ccae753
2 parents 54e853b + d78d6a3
commit ccae753
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/...rver/web/weld-integration/src/main/java/org/glassfish/weld/BeanDeploymentArchiveImpl.java b/...rver/web/weld-integration/src/main/java/org/glassfish/weld/BeanDeploymentArchiveImpl.java
@@ -252,6 +252,11 @@ public void addBeanClass(String beanClassName) {
         }
     }
 
+    @Override
+    public Collection<String> getKnownClasses() {
+        return moduleClassNames;
+    }
+
     @Override
     public BeansXml getBeansXml() {
         WeldBootstrap weldBootstrap = context.getTransientAppMetaData(WELD_BOOTSTRAP, WeldBootstrap.class);

diff --git a/appserver/web/weld-integration/src/main/java/org/glassfish/weld/DeploymentImpl.java b/appserver/web/weld-integration/src/main/java/org/glassfish/weld/DeploymentImpl.java
@@ -320,7 +320,7 @@ public BeanDeploymentArchive getBeanDeploymentArchive(Class<?> beanClass) {
 
         for (BeanDeploymentArchive beanDeploymentArchive : beanDeploymentArchives) {
             BeanDeploymentArchiveImpl beanDeploymentArchiveImpl = (BeanDeploymentArchiveImpl) beanDeploymentArchive;
-            if (beanDeploymentArchiveImpl.getBeanClassObjects().contains(beanClass)) {
+            if (beanDeploymentArchiveImpl.getKnownClasses().contains(beanClass.getName())) {
                 return beanDeploymentArchive;
             }
         }

diff --git a/...rver/web/weld-integration/src/main/java/org/glassfish/weld/RootBeanDeploymentArchive.java b/...rver/web/weld-integration/src/main/java/org/glassfish/weld/RootBeanDeploymentArchive.java
@@ -99,7 +99,7 @@ public Collection<Class<?>> getModuleBeanClassObjects() {
 
     @Override
     public BeansXml getBeansXml() {
-        return getModuleBda().getBeansXml();
+        return null;
     }
 
     @Override

diff --git a/.../web/weld-integration/src/test/java/org/glassfish/weld/RootBeanDeploymentArchiveTest.java b/.../web/weld-integration/src/test/java/org/glassfish/weld/RootBeanDeploymentArchiveTest.java
@@ -21,6 +21,7 @@
 import static org.easymock.EasyMock.expect;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertSame;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -115,6 +116,7 @@ public void testConstructor() throws Exception {
         assertEquals(WeldUtils.BDAType.UNKNOWN, rootBeanDeploymentArchive.getBDAType());
         assertEquals(0, rootBeanDeploymentArchive.getBeanClasses().size());
         assertEquals(0, rootBeanDeploymentArchive.getBeanClassObjects().size());
+        assertNull(rootBeanDeploymentArchive.getBeansXml());
 
         BeanDeploymentArchiveImpl moduleBda = (BeanDeploymentArchiveImpl) rootBeanDeploymentArchive.getModuleBda();
         assertNotNull(moduleBda);