Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provider tests in CDI TCK #23992

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix provider tests in CDI TCK #23992

merged 2 commits into from
Jun 14, 2022

Conversation

tnagao7
Copy link
Member

@tnagao7 tnagao7 commented Jun 14, 2022

This fix allows the follwing CDI TCK tests to pass:

  • CDIProviderInitTest.testAccessingBeanManager
  • CDIProviderRuntimeTest.testGetBeanManager
  • CDIProviderRuntimeTest.testLookup

See also #23961

@tnagao7
Undo commit d7822ec
c341515 
Signed-off-by: Takahiro Nagao <nagao.takahiro@fujitsu.com>
@tnagao7
Override getKnownClasses for CDI TCK
d78d6a3 
Signed-off-by: Takahiro Nagao <nagao.takahiro@fujitsu.com>
dmatej
dmatej approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome, guys, thank you! :-)

@dmatej dmatej merged commit ccae753 into eclipse-ee4j:master Jun 14, 2022
@dmatej dmatej linked an issue Jun 14, 2022 that may be closed by this pull request
CDI Test failures with GlassFish 7 #23961
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDI Test failures with GlassFish 7
2 participants
@tnagao7 @dmatej