Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give tests some love and move them >18 years forward #23507

Closed
9 tasks done
dmatej opened this issue Jul 5, 2021 · 0 comments · Fixed by #23889
Closed
9 tasks done

Give tests some love and move them >18 years forward #23507

dmatej opened this issue Jul 5, 2021 · 0 comments · Fixed by #23889
Assignees
@dmatej
Milestone
6.2.6

Comments

@dmatej
Copy link
Contributor

dmatej commented Jul 5, 2021 •
edited
Loading

Problem Description

Before we start some more rapid development, we should get the best from existing tests. So the target of this issue is to do what is possible:

  • Migrate to JUnit5
  • hk2-junitrunner is probably obsoleted, investigate alternatives
  • Clean up test dependencies (junit4 is everywhere implicitly even if unused)
  • Transform TestNG tests to JUnit5 (not maintained for a long time)
  • Resuscitate or delete disabled tests if possible (may have it's own issues, it depends on future analysis and some future plan depending on result of previous steps)
  • Integrate maven profile to run tests with JaCoCo (target: to see lines uncovered by any test, detect risks and be able to improve the state)
  • Burial of console-devtests maven project (uses obsoleted selenium and firefox, unused too long)
  • Resuscitate nucleus-tests
  • Resuscitate appserver/tests/... + quicklook

Impact of Issue

  • better coverage
  • more capabilities - ordering, parallel assertions
  • maintenance

Notes

This issue will be probably updated later as I don't see all consequences and targets yet, but from my experience they will be visible soon.
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 5, 2021
@dmatej
Issue eclipse-ee4j#23507 Dependencies with the test scope as default
e57913b 
- test-utils are an exception of the rule
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 5, 2021
@dmatej
Issue eclipse-ee4j#23507 JUnit5 and Hamcrest 2.2 are here
b1087de 
- JUnit4 depends on old hamcrest, but is compatible even with the new one
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 5, 2021
@dmatej
Issue eclipse-ee4j#23507 server-mgmgt tests transformed from testNG t…
6bd40a8 
…o junit5
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 5, 2021
@dmatej
Issue eclipse-ee4j#23507 Several fixes
13fe40f 
- with these fixes tests passed also in Eclipse editor, not just on command line
- envProperties can be null (no asenv.conf used)
- RepositoryConfig - contains suspicious code, I'm not changing the behavior
  despite it looks like a bug until I will have tests for clusters
- StringSubstitutionEngine - inputStream field was unused except constructor
- StringSubstitutionParser - javadoc now mentions that stream is closed after
  parsing
@dmatej dmatej self-assigned this Jul 9, 2021
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 20, 2021
@dmatej
Issue eclipse-ee4j#23507 Dependencies with the test scope as default
e59e081 
- test-utils are an exception of the rule
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 20, 2021
@dmatej
Issue eclipse-ee4j#23507 JUnit5 and Hamcrest 2.2 are here
272fbbf 
- JUnit4 depends on old hamcrest, but is compatible even with the new one
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 20, 2021
@dmatej
Issue eclipse-ee4j#23507 server-mgmgt tests transformed from testNG t…
946bbdc 
…o junit5
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 20, 2021
@dmatej
Issue eclipse-ee4j#23507 Several fixes
794a9a2 
- with these fixes tests passed also in Eclipse editor, not just on command line
- envProperties can be null (no asenv.conf used)
- RepositoryConfig - contains suspicious code, I'm not changing the behavior
  despite it looks like a bug until I will have tests for clusters
- StringSubstitutionEngine - inputStream field was unused except constructor
- StringSubstitutionParser - javadoc now mentions that stream is closed after
  parsing
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 Dependencies with the test scope as default
2e1bc81 
- test-utils are an exception of the rule
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 JUnit5 and Hamcrest 2.2 are here
5b23838 
- JUnit4 depends on old hamcrest, but is compatible even with the new one
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 server-mgmgt tests transformed from testNG t…
4d16257 
…o junit5
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 Several fixes
ff3d497 
- with these fixes tests passed also in Eclipse editor, not just on command line
- envProperties can be null (no asenv.conf used)
- RepositoryConfig - contains suspicious code, I'm not changing the behavior
  despite it looks like a bug until I will have tests for clusters
- StringSubstitutionEngine - inputStream field was unused except constructor
- StringSubstitutionParser - javadoc now mentions that stream is closed after
  parsing
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 rest-service now uses junit5 instead of test-ng
1632336
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 Moved resources plugin execution in rest-ser…
f3849bd 
…vice module

- to the phase process-classes, which is closer to the compilation.
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 TestNg was removed of all active modules
6d49d4e
dmatej added a commit to dmatej/glassfish that referenced this issue Jul 30, 2021
@dmatej
Issue eclipse-ee4j#23507 QuickLook tests removed
767f71e 
- just the RestTest was moved under the admin module because it tests admin's
  endpoint
- these tests will be rewritten soon in much better way
- currently they were not executed
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 QuickLook tests removed
e1ea3de 
- just the RestTest was moved under the admin module because it tests admin's
  endpoint
- these tests will be rewritten soon in much better way
- currently they were not executed
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 Added jacoco and jacoco-merge profiles
787309b 
- first is used to extend surefire/failsafe plugins and collect information
  about the test coverage. Results can be imported to Eclipse.
- second is used to collect results from all subdirectories and merge them
  to one file. This can be used to view which code is not invoked by any test
  in the build.
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 Added jacoco and jacoco-merge profiles
92fa4a2 
- first is used to extend surefire/failsafe plugins and collect information
  about the test coverage. Results can be imported to Eclipse.
- second is used to collect results from all subdirectories and merge them
  to one file. This can be used to view which code is not invoked by any test
  in the build.
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 Dependencies with the test scope as default
949ead3 
- test-utils are an exception of the rule
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 JUnit5 and Hamcrest 2.2 are here
8b5a170 
- JUnit4 depends on old hamcrest, but is compatible even with the new one
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 server-mgmgt tests transformed from testNG t…
782ef00 
…o junit5
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 Several fixes
e92b6ac 
- with these fixes tests passed also in Eclipse editor, not just on command line
- envProperties can be null (no asenv.conf used)
- RepositoryConfig - contains suspicious code, I'm not changing the behavior
  despite it looks like a bug until I will have tests for clusters
- StringSubstitutionEngine - inputStream field was unused except constructor
- StringSubstitutionParser - javadoc now mentions that stream is closed after
  parsing
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 rest-service now uses junit5 instead of test-ng
38321fb
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 Moved resources plugin execution in rest-ser…
f0d813b 
…vice module

- to the phase process-classes, which is closer to the compilation.
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 TestNg was removed of all active modules
102aba2
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 1, 2021
@dmatej
Issue eclipse-ee4j#23507 QuickLook tests removed
4ce5725 
- just the RestTest was moved under the admin module because it tests admin's
  endpoint
- these tests will be rewritten soon in much better way
- currently they were not executed
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 2, 2021
@dmatej
Issue eclipse-ee4j#23507 Added jacoco and jacoco-merge profiles
c7916bc 
- first is used to extend surefire/failsafe plugins and collect information
  about the test coverage. Results can be imported to Eclipse.
- second is used to collect results from all subdirectories and merge them
  to one file. This can be used to view which code is not invoked by any test
  in the build.
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 gftest.sh now respects some variables possibly set…
7c30041 
… by the caller
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Avoid confusing compiler by the java.lang.Record
fce1243
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Fixed NPE in WebServiceReferenceManagerImpl
ad18ab2 
- wsdl variable can be null
- reproduced by some test enabled in recent commits
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Added add-opens for java.io
1cb11bf 
- fixes issue reproducible by some of naming_all tests when using
  cluster instances
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 runtests.sh extended
eb38ffc 
- respects some externally set env properties
- removes glassfish before execution
- detects glassfish version automatically
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Main from appclient removed - it was worthless and…
cbeddd3 
… unused
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Fixed appclient classpath issues
de69523 
- bug was reproducible by several tests from recent commits
- removed endorsed as it is not supported any more
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Fixed signing jars downloaded by the appclient - s…
8001e4f 
…everal bugs

- reproducible by several tests enabled in recent commits
- removed incorrect wrapping of zip into zip
- fixed error message, reported input file as an output
- fixed closing streams
- fixed removing corrupted files (stream could be still open)
- fixed behavior when the glassfish-acc.xml file is missing
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Deleted MEJB classes
a65caf9 
- lazy init, but then crashed
- MEJB is not supported any more, see specification of Jakarta EE 9.1
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Enabled naming, deployment, security and webservic…
ff68d39 
…e tests on jenkins
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 3, 2022
@dmatej
eclipse-ee4j#23507 Updated README.md
cf41ba4
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 4, 2022
@dmatej
eclipse-ee4j#23507 Yet one forgotten ZipOutputStream removed
440c938
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 5, 2022
@dmatej
eclipse-ee4j#23507 Fixed compatibility with Jakarta EE 10
4237a49
dmatej added a commit to dmatej/glassfish that referenced this issue Mar 5, 2022
@dmatej
eclipse-ee4j#23507 Fixed compatibility with Jakarta EE 10
652822f
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 4, 2022
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests rebased to glassfish.zip and e…
5ced771 
…nabled

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 4, 2022
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests moved to appserver admin tests
57a66d9
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 4, 2022
@dmatej
eclipse-ee4j#23507 Fixed admin-tests
f7901c4 
- now they detect bugs, see next commits
- 2 tests are reproducers of bugs I could not fix easily
- new test dependency - ShrinkWrap

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej dmatej mentioned this issue Apr 4, 2022
Merged
@dmatej dmatej linked a pull request Apr 4, 2022 that will close this issue
#23507 Nucleus tests transformed to Admin tests #23889
Merged
arjantijms added a commit that referenced this issue Apr 4, 2022
@arjantijms
Merge pull request #23889 from dmatej/nucleus-tests-6.x
2be7140 
#23507 Nucleus tests transformed to Admin tests
@dmatej dmatej added this to the 6.2.6 milestone Apr 5, 2022
@dmatej dmatej removed the In Progress label Apr 5, 2022
@dmatej dmatej closed this as completed Apr 5, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 6, 2022
@dmatej
eclipse-ee4j#23507 Forgotten junit4 usage in forgotten module -> junit5
698fff0
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 6, 2022
@dmatej
eclipse-ee4j#23507 Removed usage of deprecated methods in tests
aa384a1
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 13, 2022
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests rebased to glassfish.zip and e…
9609096 
…nabled

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 13, 2022
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests moved to appserver admin tests
72b6570 
# Conflicts:
#	appserver/tests/admin/tests/pom.xml
#	nucleus/tests/pom.xml

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 13, 2022
@dmatej
eclipse-ee4j#23507 Fixed admin-tests
eb3c95f 
- now they detect bugs, see next commits
- 2 tests are reproducers of bugs I could not fix easily
- new test dependency - ShrinkWrap

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 13, 2022
@dmatej
eclipse-ee4j#23507 Forgotten junit4 usage in forgotten module -> junit5
e99fcbf
dmatej added a commit to dmatej/glassfish that referenced this issue Apr 13, 2022
@dmatej
eclipse-ee4j#23507 Using glassfish7 directory name
c1f51c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmatej dmatej

Labels
None yet
Projects
None yet
Milestone
6.2.6
Development

Successfully merging a pull request may close this issue.

#23507 Nucleus tests transformed to Admin tests dmatej/glassfish
1 participant
@dmatej