#23507 Nucleus tests transformed to Admin tests #23889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Apr 4, 2022
•
dmatej
commented
- The last checkbox of the Give tests some love and move them >18 years forward #23507 :-)
- new test dependency: ShrinkWrap: https://mvnrepository.com/artifact/org.jboss.shrinkwrap.resolver/shrinkwrap-resolver-impl-maven-archive/3.1.4 (faster and easier wars+ears for tests)
…nabled Signed-off-by: David Matějček <dmatej@seznam.cz>
- now they detect bugs, see next commits - 2 tests are reproducers of bugs I could not fix easily - new test dependency - ShrinkWrap Signed-off-by: David Matějček <dmatej@seznam.cz>
- breaks connector 1.5 xsd - See eclipse-ee4j/openmq#1432
- Pattern uses {jakarta.validation.constraints.Pattern.message} by default
Signed-off-by: David Matějček <dmatej@seznam.cz>
- errors were swallowed, so I saw just HTTP 500 without any info neither in response nor in server.log
- previous state caused an unsupported archive exception
- note one FIXME when server tries to used Jersey Client which is not on classpath
- separation - jersey/asadmin/url - shutdownHook - set of rest clients targeting usage, less confusion
9 tasks
arjantijms
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.