Drop mvn's -T option

[pzygielo]

Parallel build uses goals not marked as @threadSafe by plugins:

 [WARNING] org.glassfish.build:glassfishbuild-maven-plugin:3.2.27
 [WARNING] org.glassfish.build:spec-version-maven-plugin:2.1
 [WARNING] org.glassfish.hk2:config-generator:2.5.0-b53
 [WARNING] org.glassfish.hk2:consolidatedbundle-maven-plugin:3.0.3
 [WARNING] org.glassfish.hk2:hk2-inhabitant-generator:3.0.3
 [WARNING] org.omnifaces:antlr-maven-plugin:2.4

Thus I propose to consider not using -T option, until above are upgraded.

-Ts seem to be introduced in

• Fixed ejb tests + Fixed generating EJB classes #23770

but in that PR the usage of non-threadSafe goals and warnings from maven are not discussed.

[dmatej]

It is just a declaration, ANTLR plugin has much more serious issues, other work well. I don't see real reason for this ...?

[pzygielo]

I don't see real reason for this?

Feel free to close this then as the confirmation that the goals work correctly, please.

[dmatej]

I don't see real reason for this?

Feel free to close this then as the confirmation that the goals work correctly, please.

I don't like closing work of someone else, honestly - I forgot on these warnings for a while.
For ANTLR we have this one: #22638.
I believe other plugins should be just revisited, so perhaps us two could do that in next few days (weeks) ... If we would find that build cannot be executed in parallel, we would have to really merge this, but for 2 years I did not have any issue (always running -T4C if I am not running tests and always ok if my Eclipse IDE doesn't start compilation in parallel to Maven, which still cannot be resolved by this change).

[arjantijms]

p.s. We had the @Treadsafe marking of all these plug-ins (after testing, and manual analysis if possible/where needed) on an internal TODO many years ago.

[pzygielo]

Thanks for the feedback.

[pzygielo]

p.s. We had the @Treadsafe marking of all these plug-ins (after testing, and manual analysis if possible/where needed) on an internal TODO many years ago.

I took the liberty to make few of them public - they are referenced above. Not sure if this will make the maven warnings go away.