Fixed ejb tests + Fixed generating EJB classes #23770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rta.management.j2ee-api removal - reverted some changes from the previous commit - removed tests depending on the j2ee-api jar
…d deprecated Proxy.getProxyClass - EJB tests failed on JDK17 because of this - also more consistent generateAndLoad (to be finished in next commits)
- ejb_all/ejb_group_1/ejb_group_2/ejb_group_3/ejb_group_embedded - added add-opens where required - new group for embedded as it is significantly different than others and I often required to execute it separatedly - added -Dorg.glassfish.gmbal.no.multipleUpperBoundsException=true for the standaloneclient test stub - tests will fail, but with this commit it means that they do work!!!
- not completely as under some circumstances we cannot live without them - but we can decide when - if the class was generated in the same package, the usage and the classloader are suitable, we can use MethodHandles. Otherwise we have to use the ClassLoader.defineClass method (accessed by reflection) - we had to avoid using Base class from PFL, because it uses just MethodHandles XOR ClassLoader XOR Unsafe depending on the JDK. - this solution was tested by - glassfish's ejb_all tests with JDK11 and JDK17 - TCK/ejb with JDK11
…ot in the same package - that means that we cannot use the MethodHandles.Looku.defineClass impl
…execution's garbage
dmatej
force-pushed
the
fix-ejb-tests
branch
19 times, most recently
from
0485abb
to
1ffb6cc
Compare
dmatej
force-pushed
the
fix-ejb-tests
branch
15 times, most recently
from
e0f6237
to
7344cb1
Compare
- formatting of the code to make it easier to read - fixed several log messages (wrong formatting) - ContainerInfo used to reduce duplications - replaced several deprecated method calls with simple straight replacements - deleted 20 years old TODOs
- memory and cpu settings tested for current hardware usually used on jenkins, respecting limits - compilation without test with parallelized maven execution - upgraded jnlp - separate settings for maven and ant tests - bundles content with fast compression, excluded what we don't need
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit nonstandard, because it fixes several broken things which fixed work together. The process was long and iterative as I learned to understand the causes.
TCK test result:
