Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDC] Implement functionality to cache and re-use EDR Tokens #256

Closed
4 tasks
jzbmw opened this issue Nov 3, 2023 · 3 comments
Closed
4 tasks

[EDC] Implement functionality to cache and re-use EDR Tokens #256

jzbmw opened this issue Nov 3, 2023 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file linked_to_feature Issue is linked to a feature

Comments

@jzbmw
Copy link
Contributor

jzbmw commented Nov 3, 2023

As user,
I want that the EDR-token is cached and reused for subsequent request of assets with the same EDC contract offer,
so that we get advantages from performance

Hints / Details

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  • EDR Token caching has been implemented
  • implementation is done according to concept
  • tests have been updated
  • documentation in Arc42 has been updated

Out of Scope

  • ...
@jzbmw jzbmw changed the title 👍 [EDC] Implement functionality to cache and re-use EDR Tokens [EDC] Implement functionality to cache and re-use EDR Tokens Nov 3, 2023
@jzbmw jzbmw added the dependencies Pull requests that update a dependency file label Nov 8, 2023
@jzbmw
Copy link
Contributor Author

jzbmw commented Dec 19, 2023

Seemed to be a bigger effort than expected.
Size might be a L than a M

@ds-alexander-bulgakov
Copy link
Contributor

QA-Update: Some issues could be found during testing in the last days which could be detected by tombstone "Index 1 out of bounds for length 1" in processstep "SubmodelRequest". The reason for this could be identified and fixed in branch "edc-exception-test", retest ongoing.

@ds-alexander-bulgakov
Copy link
Contributor

ds-alexander-bulgakov commented Jan 11, 2024

No more issues could be found during last QA-review on DEV and ESS-INT, previous fixes were successful and were merged with PR #709. All three token states could be reproduced and proven with logs:
Log for new token:
"Staring new contract negotiation."

Log for existing and valid token:
"Endpoint data reference found in cache with token status valid, reusing cache record."

Log for expired token:
"Cached endpoint data reference has expired token. Refreshing token without new contract negotiation for contractAgreementId: YzY3**..."

The arch42 has been updated as well. Ticket is ready for PO-review, FYI @jzbmw.

@jzbmw jzbmw closed this as completed Jan 12, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
feat(irs-apiirs-edc-client):[#256] added cache mechanism for edr tokens
ds-jhartmann pushed a commit that referenced this issue Jan 15, 2024
feat(irs):[#256] added documentation, fixed problem with parsing authCode
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
ds-jhartmann pushed a commit that referenced this issue Feb 7, 2024
…plantuml because currently we don't support mermaid there
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
Update catena-x-environments with changes from main
ds-jhartmann pushed a commit that referenced this issue Feb 22, 2024
ds-jhartmann pushed a commit that referenced this issue Jun 14, 2024
ds-jhartmann pushed a commit that referenced this issue Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file linked_to_feature Issue is linked to a feature
Projects
Status: done
Development

No branches or pull requests

5 participants