Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resilience of github action "Publish documentation" executing on each PR #282

Closed
1 task done
mkanal opened this issue Nov 14, 2023 · 2 comments
Closed
1 task done

Improve resilience of github action "Publish documentation" executing on each PR #282

mkanal opened this issue Nov 14, 2023 · 2 comments
Assignees
@ds-jhartmann
Labels
linked_to_feature Issue is linked to a feature

Comments

@mkanal
Copy link
Contributor

mkanal commented Nov 14, 2023 •
edited
Loading

/As Developer
I want to see if markdown linting is failing on each PR
so that we have always a valid documentation on main

Hints / Details

Outcome / Acceptance Criteria

Outcome:

  • Added execution to PR (added condition to release only on main)
  • Added cache for plantuml jar to speed-up execution and save bandwith

Acceptance Criteria

  • name: Publish documentation action is executed on each PR

Out of Scope

  • ...
@ds-jhartmann ds-jhartmann self-assigned this Nov 14, 2023
@ds-jhartmann
Copy link
Contributor

ds-jhartmann commented Nov 14, 2023 •
edited by mkanal
Loading

Implemented in catenax-ng#637

@mkanal
Copy link
Contributor Author

mkanal commented Nov 15, 2023

Issue is fixed / resilience of linter is improved.
PO acceptance in representation of @jzbmw

ds-jhartmann added a commit that referenced this issue Nov 15, 2023
@ds-jhartmann
Merge remote-tracking branch 'origin/chore/#282-improve-documentation…
b5b60ef 
…-workflow' into chore/#282-improve-documentation-workflow
ds-jhartmann added a commit that referenced this issue Nov 15, 2023
@ds-jhartmann
Merge pull request #637 from catenax-ng/chore/#282-improve-documentat…
dea541d 
…ion-workflow

Chore/#282 improve documentation workflow
@mkanal mkanal removed their assignment Nov 17, 2023
@mkanal mkanal closed this as completed Nov 21, 2023
@mkanal mkanal added the linked_to_feature Issue is linked to a feature label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-jhartmann ds-jhartmann

Labels
linked_to_feature Issue is linked to a feature
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ds-jhartmann @mkanal