Feature/did document fields + add service entry for token endpoint #298
Conversation
andreibogus
changed the title
| @@ -102,4 +102,7 @@ private StringPool() { | |||
|
|
|||
| public static final String PRIVATE_KEY = "PRIVATE KEY"; | |||
| public static final String PUBLIC_KEY = "PUBLIC KEY"; | |||
| public static final String VERIFICATION_METHOD_TYPE = "JsonWebKey2020"; | |||
There was a problem hiding this comment.
we already have a constant in SSI lib for JsonWebKey2020 : JWKVerificationMethod.DEFAULT_TYPE
| public class MIWVerifiableCredentialType { | ||
|
|
||
| /** The constant MEMBERSHIP_CREDENTIAL. */ | ||
| public static final String MEMBERSHIP_CREDENTIAL = "MembershipCredential"; |
There was a problem hiding this comment.
We already have constant in SSI lib VerifiableCredentialType.MEMBERSHIP_CREDENTIAL
| */ | ||
| @SneakyThrows | ||
| public String getWalletKeyIdByWalletId(long walletId) { | ||
| return walletKeyRepository.getByWalletId(walletId).getKeyId(); |
There was a problem hiding this comment.
Can we write a JPA query to fetch only keyid from the table instead of the whole object? ie. select keyId from WalletKey where walletId:=id
| mutableContext.add(uri); | ||
| } | ||
| }); | ||
| didDocument.put("@context", mutableContext); |
There was a problem hiding this comment.
use constant JsonLdObject.CONTEXT
| didDocument = DidDocument.fromJson(didDocument.toJson()); | ||
|
|
||
| didDocument.put(ASSERTION_METHOD, List.of(jwkVerificationMethod.getId())); | ||
| Map<String, Object> serviceData = Map.of("id", did.toUri(), "type", "CredentialService", |
There was a problem hiding this comment.
use constant from Verifiable for id and type
|
|
||
| didDocument.put(ASSERTION_METHOD, List.of(jwkVerificationMethod.getId())); | ||
| Map<String, Object> serviceData = Map.of("id", did.toUri(), "type", "CredentialService", | ||
| "serviceEndpoint", HTTPS_SCHEME + miwSettings.host() + "/api/token"); |
There was a problem hiding this comment.
use Service.SERVICE_ENDPOINT
| @@ -175,7 +186,24 @@ void createWalletTest201() throws JsonProcessingException, JSONException { | |||
|
|
|||
| Assertions.assertNotNull(response.getBody()); | |||
| Assertions.assertNotNull(wallet.getDidDocument()); | |||
| Assertions.assertEquals(2, wallet.getDidDocument().getVerificationMethods().size()); | |||
| List<VerificationMethod> verificationMethods = wallet.getDidDocument().getVerificationMethods(); | |||
There was a problem hiding this comment.
Can we write separate test cases to verify verification methods instead of modifying existing ones?
ie. Create a wallet with random BPN and then verify did document and verification method?
|
Closing this PR as there has been no response from the author of this PR for a long time. Changes are completed with: #325 |
This is implementation of enhancements: did document fields and "add service entry for token endpoint".
Closes: #292, #296
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: