feat: did document update #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
There was a problem hiding this comment.
Code changes are fine
It is good if can add support of service and assertionMthod inside DidDocumentBuilder and DidDocument in the SSI lib project.
@borisrizov-zf Please suggest whether we should merge this PR and letter add support in SSI lib or we should first do changes in SSI lib and publish new version?
miw/src/main/java/org/eclipse/tractusx/managedidentitywallets/constant/StringPool.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/managedidentitywallets/service/JwtPresentationES256KService.java
Outdated
Show resolved
Hide resolved
borisrizov-zf
approved these changes
Jul 18, 2024
|
🎉 This issue has been resolved in version 0.6.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an implementation of enhancements: did document fields and "add service entry for token endpoint".
More details in #292, #296
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: