Feat/register parttype at edc #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../org/eclipse/tractusx/puris/backend/masterdata/controller/PartTypeInformationController.java
Dismissed
Show resolved
Hide resolved
tom-rm-meyer-ISST
requested changes
Mar 19, 2024
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/common/edc/logic/util/EdcRequestBodyBuilder.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/common/edc/logic/util/EdcRequestBodyBuilder.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/tractusx/puris/backend/masterdata/controller/PartTypeInformationController.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/puris/backend/masterdata/logic/service/MaterialPartnerRelationServiceImpl.java
Show resolved
Hide resolved
.../org/eclipse/tractusx/puris/backend/masterdata/controller/PartTypeInformationController.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Mar 19, 2024
tom-rm-meyer-ISST
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Great update! I faulty desribed the semantic id with @id which should be a nested object same as dct:type. All findings are rather small :)
...ain/java/org/eclipse/tractusx/puris/backend/common/edc/logic/util/EdcRequestBodyBuilder.java
Outdated
Show resolved
Hide resolved
| @Autowired | ||
| private PartTypeInformationSammMapper sammMapper; | ||
|
|
||
| @Operation(description = "Ednpoint that delivers PartTypeInformation of own products to customer partners. " + |
There was a problem hiding this comment.
Small typo Ednpoint -> Endpoint
.../org/eclipse/tractusx/puris/backend/masterdata/controller/PartTypeInformationController.java
Show resolved
Hide resolved
tom-rm-meyer-ISST
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure to do as many of the following checks as possible, before asking for committer review: