Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added trufflehog secret scanning tool #531

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: Added trufflehog secret scanning tool #531

merged 2 commits into from
Aug 8, 2024

Conversation

RoKrish14
Copy link
Contributor

@RoKrish14 RoKrish14 commented Jul 30, 2024 •
edited by tom-rm-meyer-ISST
Loading

Description

This PR introduces TruffleHog as a new open source tool for secret scanning to be used alongside native Github Secret scanning. This is being enforced as a replacement to the existing GitGuardian (commercial) tool.

Update trg-8-03.md

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@RoKrish14 RoKrish14 self-assigned this Jul 30, 2024
@RoKrish14 RoKrish14 changed the title Create trufflehog.yml chore: Added trufflehog secret scanning tool Jul 30, 2024
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing! Please check comments :)

.github/workflows/trufflehog.yml Show resolved Hide resolved
.github/workflows/trufflehog.yml Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, workflow runs through. Thanks for providing!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 9adfcce into eclipse-tractusx:main Aug 8, 2024
13 checks passed
@RoKrish14
Copy link
Contributor Author

Thanks @tom-rm-meyer-ISST for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

@mhellmeier mhellmeier Awaiting requested review from mhellmeier

Assignees

@RoKrish14 RoKrish14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoKrish14 @tom-rm-meyer-ISST