docs: update trg-8-03.md, introduce TruffleHog #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaGru3n
reviewed
Jul 1, 2024
This was referenced Jul 29, 2024
Merged
FaGru3n
approved these changes
Aug 1, 2024
|
NOTE: Please do not merge this PR until the August release |
|
@RoKrish14 you could have placed it as a draft then |
|
@eclipse-tractusx/automotive-tractusx-committers please review |
tom-rm-meyer-ISST
previously approved these changes
Aug 8, 2024
ndr-brt
reviewed
Aug 8, 2024
docs/release/trg-8/trg-8-03.md
Outdated
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 # Ensure full clone for pull request workflows | ||
| ref: ${{ github.head_ref }} # Fetch specific branch/commit for pull requests |
ndr-brt
reviewed
Aug 8, 2024
evegufy
changed the title
|
@RoKrish14 are you still integrating review comments? |
|
@RoKrish14 Are you still working on this issue? I think we have a consensus on how we want to proceed here. Please get back by the end of next week, otherwise we would create a new PR for this topics. Thank you! |
Co-authored-by: Tom Meyer <tom.meyer@isst.fraunhofer.de>
Co-authored-by: ndr_brt <andrea.bertagnolli@gmail.com>
|
@evegufy and @danielmiehle : Apologies for the delay as I was on vacation. |
ndr-brt
approved these changes
Aug 23, 2024
tom-rm-meyer-ISST
approved these changes
Aug 26, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces TruffleHog as a new open source tool for secret scanning to be used alongside native Github Secret scanning. This is being enforced as a replacement to the existing GitGuardian (commercial) tool.
Example workflow:
Please note: The TRG checks continues for 24.08 under GitGuardian for secret scanning.
The teams who have already implemented TruffleHog, can also be considered for the TRG checks.
NOTE: Please do not merge this PR until the August release
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: