Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added trufflehog secret scanning tool #162

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

RoKrish14
Copy link
Contributor

@RoKrish14 RoKrish14 commented Jul 30, 2024

Description

This PR introduces TruffleHog as a new open source tool for secret scanning to be used alongside native Github Secret scanning. This is being enforced as a replacement to the existing GitGuardian (commercial) tool.

Update trg-8-03.md

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@RoKrish14 RoKrish14 self-assigned this Jul 30, 2024
Copy link

sonarcloud bot commented Aug 23, 2024

@RoKrish14
Copy link
Contributor Author

I would like know if there are any blockers to review and merge this PR.

@agg3fe
Copy link
Contributor

agg3fe commented Sep 10, 2024

I would like know if there are any blockers to review and merge this PR.

Hi Rohan, no blockers. I will merge it. Will do the same for other repositories also. Do I need to make any changes here for other repos?

@RoKrish14
Copy link
Contributor Author

I have created PR in other repo's too. Feel free to make updates if needed. Nothing to be done here.

@RoKrish14 RoKrish14 merged commit 51cca1d into eclipse-tractusx:main Sep 10, 2024
9 checks passed
@agg3fe
Copy link
Contributor

agg3fe commented Sep 10, 2024

I have created PR in other repo's too. Feel free to make updates if needed. Nothing to be done here.

Actually I can't find the same PRs for below repos, could you please help me if you have raised for these repos also:
https://github.com/eclipse-tractusx/sldt-digital-twin-registry/pulls
https://github.com/eclipse-tractusx/sldt-bpn-discovery/pulls
https://github.com/eclipse-tractusx/sldt-semantic-hub/pulls

@RoKrish14
Copy link
Contributor Author

RoKrish14 commented Sep 10, 2024

Sadly, none of these. I had randomly chosen few repo's so that every other product lines can be smoothly onboarded.
For SLDT, I chose only one repo to present the PR which can stand as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants