[Feature] Dark mode #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies the theme variant (light/dark/system) as specified in the settings modal. If the 'system' setting is used, we use window matchMedia queries to check the system theme mode.
Also remove 'midnight' theme since it was used to create the default dark theme
- `default` dark's active sidebar color is the same bright yellow as default light - All white border lines are made dark grey in the dark themes - Active sidebar item looks more like a banner than a box - `xcode-civic` link color is now orange
If a user's local storage is corrupted or specifies a deprecated subtheme name, ignore the value from local storage and use the 'default' theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we live in the era of dark mode and auto-switching themes, I think many users may appreciate if Primer Spec switched between a light and dark theme automatically based on the system settings.
After speaking with @bellakiminsun, we decided that we liked Slack's approach to dark-mode the best — each Slack theme has a light variant and a dark variant, and Slack lets users customize whether the variants/modes switch with the system settings.
This PR adds a first-pass implementation of auto-dark mode inspired by Slack:
default,bella,modernandxcode-civiclight,dark,system(default)systemmode, the theme changes between light and dark modes based on the system settings.Validation:
Visit the preview URL for this PR, and play around with different combinations of the subthemes and modes. Also play around with your system settings for light/dark mode and verify their interaction with the Primer Spec site's subtheme.