Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Dark mode #49

Merged
merged 9 commits into from
Apr 25, 2020
Merged

[Feature] Dark mode #49

merged 9 commits into from
Apr 25, 2020

Commits on Apr 19, 2020

  1. Refactor subtheme definitions to support light and dark modes

    @seshrs
    seshrs committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    a1f15dc View commit details
    Browse the repository at this point in the history

  2. Expose subtheme mode selector in settings modal 

    This commit applies the theme variant (light/dark/system) as specified in the settings modal. If the 'system' setting is used, we use window matchMedia queries to check the system theme mode.
    @seshrs
    seshrs committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    53288b2 View commit details
    Browse the repository at this point in the history

  3. Create dark variants for each theme 

    Also remove 'midnight' theme since it was used to create the default dark theme
    @seshrs
    seshrs committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    0db8a1e View commit details
    Browse the repository at this point in the history

  4. Fix bug with subtheme settings not updating mode correctly

    @seshrs
    seshrs committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    1727d85 View commit details
    Browse the repository at this point in the history

  5. Rename 'xcode-dark' to 'xcode-civic'

    @seshrs
    seshrs committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    87e7cde View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Updates based on @bellakiminsun's feedback 

    - `default` dark's active sidebar color is the same bright yellow as default light
- All white border lines are made dark grey in the dark themes
- Active sidebar item looks more like a banner than a box
- `xcode-civic` link color is now orange
    @seshrs
    seshrs committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    842df61 View commit details
    Browse the repository at this point in the history

  2. Float sidebar toggle icon to the right

    @seshrs
    seshrs committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    025ded2 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Validate stored subtheme name against available subthemes 

    If a user's local storage is corrupted or specifies a deprecated subtheme name, ignore the value from local storage and use the 'default' theme.
    @seshrs
    seshrs committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    0cd609e View commit details
    Browse the repository at this point in the history

  2. Increase sidebar item padding

    @seshrs
    seshrs committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    5c03edb View commit details
    Browse the repository at this point in the history