-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive web cleanup. #790
base: main
Are you sure you want to change the base?
Massive web cleanup. #790
Conversation
@@ -11,7 +11,7 @@ | |||
"inputLabel": "How can I help you?", | |||
"titleOperationName": "generate_title", | |||
"allowSpeech": true, | |||
"speechAgent": "speech-agent", | |||
"speechAgent": "speech_agent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the agent with a -, we can't use _ in k8's names so need to start migrating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original has the hyphen
Also changed AgentProgram and friends to allow for the title of an operation to be set.
Cleaned up statement for apps, processes, process updates and more Fixed title handling for simple agent in python code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems this creates with the quickstart:
- It is now too many clicks to use the hello world agent (3), we should expand the first agent in the list.
- Converse (the action name) is duplicated. Why is this? is it grabbing the action description? if so this can be updated in the quickstart, not this pr
- [object, Object] text indicates that it does not handle plain/text body types well
- defaulting to the same input as the previous request is probably not desired behavior
@@ -122,6 +123,7 @@ class StringOutputEvent(OutputEvent): | |||
class ObjectOutputEvent(OutputEvent, Generic[T]): | |||
event_type: Literal["object"] = "object" | |||
content: T | |||
hidden: Optional[bool] = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden becomes very ui specific. Perhaps it would be better to add a metadata object to any event, and then we can throw this in there?
If not, this shouldn't be Optional[bool], just make it a bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "internal"? There are, and will likely be more of, events we don't want any UI to render, like this one.
The display is <title>(). I will not emit the second if they are the same, but we should update the Quickstart (and others) to have titles |
I didn't everything but hidden -> internal. LMK |
Massive cleanup to the webUI.
First some architectural changes:
Python changes:
LAF changes:
header is now more inline with the eidolonai website and removed login button.