Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive web cleanup. #790

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Massive web cleanup. #790

wants to merge 28 commits into from

Conversation

dbrewster
Copy link
Collaborator

@dbrewster dbrewster commented Sep 19, 2024

Massive cleanup to the webUI.

First some architectural changes:

  • Removed material design (mui) and mii-icons
  • Replaced with tailwind and lucide
  • Added SIMPLE hooks for getApp, getProcess, and getProcesses. The getProcess has an update hook on it so the UI can update when it needs to (for things like background title changes). This greatly simplified the components.
  • Made dev tool and chatbot tool more inline with each other. Only divergence now is the main page (for each app) and the input panel.

Python changes:

  • Added / cleaned up support for title and subtitle on agents and tools. You can now specify the title / subtitle for each and they appear in the UI correctly.
  • Cleaned up when isAgent is set on events.
  • Added a "hidden" flag to object output and string output events. Idea is these are events internal to the app and shouldn't be shown to a user.
  • Made a change to simple agent where it now generates the title automatically for you, in the background, and sets the process title correctly.

LAF changes:

  • header is now more inline with the eidolonai website and removed login button.
    Uploading Home Page.png…

@@ -11,7 +11,7 @@
"inputLabel": "How can I help you?",
"titleOperationName": "generate_title",
"allowSpeech": true,
"speechAgent": "speech-agent",
"speechAgent": "speech_agent",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the agent with a -, we can't use _ in k8's names so need to start migrating

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original has the hyphen

Also changed AgentProgram and friends to allow for the title of an operation to be set.
dbrewster and others added 2 commits September 22, 2024 21:44
Cleaned up statement for apps, processes, process updates and more
Fixed title handling for simple agent in python code
Copy link
Collaborator

@LukeLalor LukeLalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems this creates with the quickstart:

  1. It is now too many clicks to use the hello world agent (3), we should expand the first agent in the list.
  2. Converse (the action name) is duplicated. Why is this? is it grabbing the action description? if so this can be updated in the quickstart, not this pr
  3. [object, Object] text indicates that it does not handle plain/text body types well
  4. defaulting to the same input as the previous request is probably not desired behavior
Screenshot 2024-09-25 at 8 16 25 AM Screenshot 2024-09-25 at 8 16 31 AM Screenshot 2024-09-25 at 8 16 42 AM Screenshot 2024-09-25 at 8 15 31 AM

@@ -122,6 +123,7 @@ class StringOutputEvent(OutputEvent):
class ObjectOutputEvent(OutputEvent, Generic[T]):
event_type: Literal["object"] = "object"
content: T
hidden: Optional[bool] = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden becomes very ui specific. Perhaps it would be better to add a metadata object to any event, and then we can throw this in there?

If not, this shouldn't be Optional[bool], just make it a bool

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "internal"? There are, and will likely be more of, events we don't want any UI to render, like this one.

@dbrewster
Copy link
Collaborator Author

The display is <title>(). I will not emit the second if they are the same, but we should update the Quickstart (and others) to have titles

@dbrewster
Copy link
Collaborator Author

I didn't everything but hidden -> internal. LMK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants